add ability to lock axes

[M-Kusumgar]

This lets users lock the axes to give a better comparison of how the graph changes between runs. Users can simply toggle the lock axes checkbox in graph settings and this disables zoom on the graph, locks the axes so that any subsequent updates have the same view range and domain.

To test try out this code in wodin:

r <- user(0.1)    # Birth rate
N_init <- user(1) # Initial population size

# The step size, in units of time
dt <- 0.01
# The current time is the number of steps taken multiplied by the step size
time <- step * dt

# Deterministic solution
initial(N_det) <- N_init
update(N_det) <- N_init * exp(r * time)

# Stochastic solution
initial(N_stoch) <- N_init

# We can use rbinom to generate N_stoch random samples from the 
# binomial distribution with probability r * dt
n_birth <- rbinom(N_stoch, r * dt) 

update(N_stoch) <- N_stoch + n_birth

If you keep re-running it you can see the y axis changes a lot.

To remember the last axes ranges we store them in state. You can also zoom in when you haven't locked axes and then lock them in a smaller view! On lock or unlock of the axes the graph redraws with autorange as before.

[codecov]

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed	Coverage
...tatic/src/app/store/graphSettings/graphSettings.ts	ø
app/static/src/app/components/WodinPlot.vue	100.00%
...tatic/src/app/components/options/GraphSettings.vue	100.00%
...pp/static/src/app/store/graphSettings/mutations.ts	100.00%

📢 Thoughts on this report? Let us know!.

[richfitz]

Suggested change

	<label class="col-form-label">Lock axes</label>
	<label class="col-form-label">Lock y axis range</label>

[M-Kusumgar]

as discussed, this actually locks both axes (for example when someone zooms in on the graph), if i dont lock both then the x axis autoscales when youre zoomed in which gives the graph a stretch that wasn't there before!

[richfitz]

An exciting thing happens if you interact with the log scale toggle too.

1. Start with your example showing exponential growth
2. Lock the y axis
3. Select "log scale"

Now the y axis will go to something like 10^61800 and the lines are all along the bottom.

It's not the end of the world - unlocking the axis returns to sensible values, and then you can relock the axis and it behaves well in log mode. But this does not tolerate well moving between those modes

[M-Kusumgar]

fixed!

[richfitz]

has this PR changed the plotly config to remove the floating bar (despite this saying true)? People use that to download plots so it's important to retain. I see it's there on the version on wodin-dev still at least

[M-Kusumgar]

ahh good point, it was setting it as false because i thought it would have controls for zoom, allowing users to bypass the zoom lock when axes are locked, however plotly is smart and if i lock the axes then the zoom options dont show up! so it is added back in

[richfitz]

thanks, this is fab

[EmmaLRussell]

LGTM. Bit confused about where we got to with the zoomability. I do still seem to be able to zoom with axes locked, but then it snaps back to the locked range on re-run.

[EmmaLRussell]

So this means it always does autorange if we're updating because of logScale value change?

[M-Kusumgar]

Yes so the log scale completely changes the axis, if you lock the axis as before there are very weird things y axis values, so instead we don't lock y axis when they toggle between the log and normal scale

[M-Kusumgar]

LGTM. Bit confused about where we got to with the zoomability. I do still seem to be able to zoom with axes locked, but then it snaps back to the locked range on re-run.

Ahh sorry forgot to update the comment, in the first implementation, they could not zoom in but instead keep the viewport fixed! But this is not what we wanted so now they can zoom in as before but it locks the y axis on re run essentially