mrc-3700 Delete session from front end storage

[EmmaLRussell]

This branch adds a column to the Sessions page allowing users to delete sessions from the list - this removes the session id from local storage, and from current store metadata. The session remains in the backend, so any links to it will continue to work.

Clicking a Delete icon shows a confirm dialog before doing the actual delete - we haven't generally used this approach for deletes, but accidentally deleting a session would be pretty annoying..

The user cannot delete the current session.

[codecov]

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed	Coverage
app/static/src/app/components/ConfirmModal.vue	100.00%
...tatic/src/app/components/sessions/SessionsPage.vue	100.00%
app/static/src/app/localStorageManager.ts	100.00%
app/static/src/app/store/sessions/actions.ts	100.00%
app/static/src/app/store/sessions/mutations.ts	100.00%

📢 Thoughts on this report? Let us know!.

[richfitz]

This looks and works great. The modal is not at all annoying, either

[M-Kusumgar]

before i start reviewing the code, found a bug, don't think it is to do with what youve done this PR but just want to confirm, if not i can make a ticket, if you do these steps:

1. Load app
2. Go on sensitivity tab (RHS)
3. Go on options tab (LHS)
4. Go to sessions and load your current session as a new one
5. Go to options tab, you see sensitivity options when you are on the run app

I think most likely we are either not serialising the tab or we are not updating it on load!

[M-Kusumgar]

This works very well! Just a small comment about refreshing the sessions page but not something to stop this from being merged!

[M-Kusumgar]

Not sure if this is even worth it or not but you get sessions on mount however lets say you are on the sessions page and you refresh, then you will see only the old session because the new session has not been posted yet, so you can delete all the sessions you see, of course this is fine because the new session is just being posted but i wonder if you can wait for the new session post and then show the list of session, again really dont think it is that worth it but something to keep in mind

[EmmaLRussell]

I think that's probably ok - if you refresh then you expect to lose your current session and its special status.

[EmmaLRussell]

before i start reviewing the code, found a bug, don't think it is to do with what youve done this PR but just want to confirm, if not i can make a ticket, if you do these steps:

1. Load app

2. Go on sensitivity tab (RHS)

3. Go on options tab (LHS)

4. Go to sessions and load your current session as a new one

5. Go to options tab, you see sensitivity options when you are on the run app

I think most likely we are either not serialising the tab or we are not updating it on load!

Yep, that's a good one, definitely not anything to do with these changes. I think it's probably caused by some stale state not getting updated on new session. Would you mind creating a ticket?