feat(secp256k1): add endomorphism acceleration #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bench from
35us vs our 46us so we need a 24% perf improvement to catchup. This should be easy by not using Montgomery domain and implementing fast reduction. |
mratsim
added a commit
that referenced
this pull request
Aug 19, 2024
mratsim
added a commit
that referenced
this pull request
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of a series of PR to bring secp256k1 performance to state-of-the-art and then beyond.
See overall steps in #285.
Benchmarks
Unfortunately the most important primitive field multiplication does not use assembly for secp256k1 (256-bit) at the moment. Hence the huge gap (~30%) with the Pallas curve (255-bit) for example.