Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ios-example #9

Merged
merged 2 commits into from
Jul 27, 2024
Merged

Add ios-example #9

merged 2 commits into from
Jul 27, 2024

Conversation

dustinbowers
Copy link
Contributor

@dustinbowers dustinbowers commented Jul 27, 2024

This PR includes:

  • Rust project
  • Xcode project

The Xcode project is configured to include the necessary C header file, link the required libraries, and build the rust library when the project is built.

This example includes cleanup of the audio device when the App isn't active (otherwise the audio device would stay running even if the app is minimized)

(Also I'm not sure if it's appropriate to include the Xcode project in the example, because it makes some assumptions about usage. I've included it here because it actually does require a bit of setup to get Rust and Xcode to play nicely with each other)

@dustinbowers dustinbowers mentioned this pull request Jul 27, 2024
@mrDIMAS
Copy link
Owner

mrDIMAS commented Jul 27, 2024

Box<dyn BaseAudioOutputDevice> should be replaced with OutputDevice.

@dustinbowers
Copy link
Contributor Author

I don't follow... I can't make that work for ios

@mrDIMAS
Copy link
Owner

mrDIMAS commented Jul 27, 2024

I mean CI has failed because there was this commit c8c1bc3 and it seems that you've used previous version without it. You're currently using Box<dyn BaseAudioOutputDevice>, but BaseAudioOutputDevice is now private trait. So Box<dyn BaseAudioOutputDevice> is now replaced with OutputDevice. You probably need to just rebase your changes using the latest code.

@mrDIMAS mrDIMAS merged commit 2ea2d3f into mrDIMAS:main Jul 27, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants