Skip to content
This repository has been archived by the owner on Oct 11, 2021. It is now read-only.

upgrade deps, refactor source handler to work with meteor 1.2 #99

Merged
merged 2 commits into from
Sep 23, 2015
Merged

upgrade deps, refactor source handler to work with meteor 1.2 #99

merged 2 commits into from
Sep 23, 2015

Conversation

aaronjudd
Copy link
Contributor

updates to bower 1.5.2
Resolves #97

@@ -236,11 +241,8 @@ var sortDependencies = function(dependencies) {
// This is a Meteor bug.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also remove this now obsolete comment.

@mquandalle
Copy link
Owner

Woah, thanks! Now that Meteor 1.2 is out we should merge this ASAP. This looks good to me from a quick review, but I haven't tested the code yet. @aaronjudd Could you comment a little bit more on the changes you have made? @lorensr what do you think of this?

@lorensr
Copy link
Collaborator

lorensr commented Sep 23, 2015

rm -rf .meteor/local/bower
meteor update
meteor

.meteor/local/bower is not created. When using pull/99/head, packages are correctly downloaded and shipped to client. Don't have a comprehensive suite of bower.jsons though, just my own. Does not regress on the security issue.

@aaronjudd
Copy link
Contributor Author

@lorensr
I tested with a clean project, with only bower added, created a lib dir, dropped in a pretty big bower.json and it worked without issue (and created .meteor/local/bower). Also have tested within a package (my main use case is installing lib in a package) - and that works. However - I noticed that the directory did not seem to be created with Meteor 1.2.0 - but does work with Meteor 1.2.0.1. Are you testing with an older Meteor release? I would think these changes would be backward compatible, but didn't test.

@lorensr
Copy link
Collaborator

lorensr commented Sep 23, 2015

I'm on 1.2.0.1 – sorry, your PR works for me – first part of my comment was
just confirming that the currently-published version of bower doesn't work.

On Wed, Sep 23, 2015 at 1:29 AM, Aaron Judd [email protected]
wrote:

@lorensr https://github.com/lorensr
I tested with clean project, with only bower added, created a lib dir,
dropped in a pretty big bower.json and it worked without issue (and created
.meteor/local/bower). Also have tested within a package (my main use case
is installing lib in a package) - and that works. However - I noticed that
the directory did not seem to be created with Meteor 1.2.0 - but does work
with Meteor 1.2.0.1. Are you testing with an older Meteor release? I would
think these changes would be backward compatible, but didn't test.


Reply to this email directly or view it on GitHub
#99 (comment)
.

@aaronjudd
Copy link
Contributor Author

Ah- great. Made me do some extra testing though, so not a bad thing.

@aaronjudd
Copy link
Contributor Author

@lorensr @mquandalle merge and publish?

mquandalle added a commit that referenced this pull request Sep 23, 2015
upgrade deps, refactor source handler to work with meteor 1.2
@mquandalle mquandalle merged commit 5a6ab5e into mquandalle:master Sep 23, 2015
@mquandalle
Copy link
Owner

Done, thank you very much :-)

@lscordilis
Copy link

Thanks very much for the quick fix, guys. I think I speak for the community when I say Meteor-bower is still a great and popular tool and we really appreciate the continued support.

@allanlundhansen
Copy link

Great fast work thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants