-
Notifications
You must be signed in to change notification settings - Fork 28
WIP: Port the package to the new Meteor 1.2+ Compiler API #94
Conversation
@mquandalle now that Meteor 1.2 is released, will you be merging this? Or is more work necessary? |
@stubailo Was it expected that Meteor 1.2 broke the old compileStep API (in bower case)? |
No, I don't think so - what's the specific issue? |
@mquandalle Any update on this? Meteor 1.2 has released and this issue with Meteor-bower not loading dependencies properly has completely broken my angular-meteor projects, because the modules don't exist to be injected into the app. |
@lscordilis Porting this package to the new compiler API is a lot of work (and as I'm not using bower anymore it's not my top priority). @stubailo seems to say that the old API should still work, so maybe we can find what the issue is, and make the minimum viable change to fix #97. |
Hm, that's unfortunate. Why aren't you using bower anymore? Also, is there anything I can do to work around this, such as reference the bower packages manually? |
Bower not working for me after updating to Meteor 1.2. |
From this conversation it seems that we should now use build plugin caching instead of putting bower files under the |
@mquandalle yes that is correct - do we need to better document the new build plugin system? It is a good amount more complicated than the previous one, but has a lot more flexibility. A good example to look at would be: https://github.com/meteor/meteor/tree/devel/packages/caching-compiler |
Closing, as I don’t plan to finish that. |
Makes sense to me! |
when meteor 1.3 comes, should we deprecate in favor of npm? http://guide.meteor.com/build-tool.html#client-npm |
Yes, I think so |
Do not merge.