Skip to content
This repository has been archived by the owner on Oct 11, 2021. It is now read-only.

WIP: Port the package to the new Meteor 1.2+ Compiler API #94

Closed
wants to merge 1 commit into from

Conversation

mquandalle
Copy link
Owner

Do not merge.

@aaronjudd
Copy link
Contributor

@mquandalle now that Meteor 1.2 is released, will you be merging this? Or is more work necessary?

@mquandalle
Copy link
Owner Author

@stubailo Was it expected that Meteor 1.2 broke the old compileStep API (in bower case)?

@stubailo
Copy link

No, I don't think so - what's the specific issue?

@mquandalle
Copy link
Owner Author

I haven't investigate but the bug (reported by multiple people) is described in #97, and the current source handler here.

@lscordilis
Copy link

@mquandalle Any update on this? Meteor 1.2 has released and this issue with Meteor-bower not loading dependencies properly has completely broken my angular-meteor projects, because the modules don't exist to be injected into the app.

@mquandalle
Copy link
Owner Author

@lscordilis Porting this package to the new compiler API is a lot of work (and as I'm not using bower anymore it's not my top priority). @stubailo seems to say that the old API should still work, so maybe we can find what the issue is, and make the minimum viable change to fix #97.

@lscordilis
Copy link

Hm, that's unfortunate. Why aren't you using bower anymore? Also, is there anything I can do to work around this, such as reference the bower packages manually?

@v3rron
Copy link

v3rron commented Sep 22, 2015

Bower not working for me after updating to Meteor 1.2.
I only have one package there: twitter.short, and it's not working:
TypeError: moment(...).twitterShort is not a function

@mquandalle
Copy link
Owner Author

From this conversation it seems that we should now use build plugin caching instead of putting bower files under the .meteor directory.

@stubailo
Copy link

@mquandalle yes that is correct - do we need to better document the new build plugin system? It is a good amount more complicated than the previous one, but has a lot more flexibility.

A good example to look at would be: https://github.com/meteor/meteor/tree/devel/packages/caching-compiler

@mquandalle
Copy link
Owner Author

Closing, as I don’t plan to finish that.

@mquandalle mquandalle closed this Jan 8, 2016
@stubailo
Copy link

stubailo commented Jan 8, 2016

Makes sense to me!

@lorensr
Copy link
Collaborator

lorensr commented Jan 10, 2016

when meteor 1.3 comes, should we deprecate in favor of npm? http://guide.meteor.com/build-tool.html#client-npm

@mquandalle
Copy link
Owner Author

Yes, I think so

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants