Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser): bump [email protected] to fix BigInt issues #1963

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

robertsLando
Copy link
Member

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.15%. Comparing base (df2e8fe) to head (9f5f272).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1963   +/-   ##
=======================================
  Coverage   81.15%   81.15%           
=======================================
  Files          24       24           
  Lines        1470     1470           
  Branches      349      349           
=======================================
  Hits         1193     1193           
  Misses        193      193           
  Partials       84       84           
Flag Coverage Δ
unittests 81.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robertsLando
Copy link
Member Author

@MaximoLiberata electron tests started failing, any clue why?

@robertsLando robertsLando merged commit 9749891 into main Jan 28, 2025
8 of 9 checks passed
@robertsLando robertsLando deleted the readable-stream-bump branch January 28, 2025 10:12
@MaximoLiberata
Copy link
Contributor

Hi @robertsLando, right now I don't have any clue, I will take a look this weekend.

@robertsLando
Copy link
Member Author

Thanks!

@MaximoLiberata
Copy link
Contributor

MaximoLiberata commented Feb 3, 2025

Hi @robertsLando,

I've tried to run electron's tests and they failed on my local, I moved to previous commits and they still fail.

It seems like an internal issue with electron app startup, nothing to do with the tests.

I haven't found a solution yet.

@robertsLando
Copy link
Member Author

@MaximoLiberata Thanks for the quick update, let me know if you find a fix 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants