Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom websocket support #1696

Merged
merged 1 commit into from
Sep 19, 2023
Merged

feat: custom websocket support #1696

merged 1 commit into from
Sep 19, 2023

Conversation

helios57
Copy link
Contributor

@helios57 helios57 commented Sep 18, 2023

We need to add special protocols to connect to our mqtt broker over websocket. With this small addition (which hopefully helps others as well) we can do it very easy. Otherwhise we need to build our own streamBuilder and copy alot code.

Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test that covers this feature and also mention it in docs

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 16.66% and project coverage change: -0.24% ⚠️

Comparison is base (827daa8) 81.09% compared to head (b062036) 80.86%.

❗ Current head b062036 differs from pull request most recent head 891aaff. Consider uploading reports for the commit 891aaff to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1696      +/-   ##
==========================================
- Coverage   81.09%   80.86%   -0.24%     
==========================================
  Files          21       21              
  Lines        1365     1369       +4     
  Branches      322      324       +2     
==========================================
  Hits         1107     1107              
- Misses        181      184       +3     
- Partials       77       78       +1     
Files Changed Coverage Δ
src/lib/client.ts 85.83% <ø> (ø)
src/lib/connect/ws.ts 35.65% <16.66%> (-1.15%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@helios57
Copy link
Contributor Author

Thanks for the fast response. Unittest is now added and the docs should be updated.

@robertsLando robertsLando enabled auto-merge (squash) September 19, 2023 07:26
@robertsLando robertsLando merged commit d6fd3a8 into mqttjs:main Sep 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants