-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add mqtt 5 beta banner and sponsors section #1617
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1617 +/- ##
=======================================
Coverage 86.22% 86.22%
=======================================
Files 13 13
Lines 1314 1314
=======================================
Hits 1133 1133
Misses 181 181 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Vishnu Reddy <[email protected]>
cc @mcollina just to inform you, a sponsor section has been added to project README |
Tests are flaky, hopefully #1534 will fix this |
@vishnureddy17 FYI I tried to make a new beta release using the workflow. It went well except for the last step where it should push the release and changelog to main branch: https://github.com/mqttjs/MQTT.js/actions/runs/5409237552/jobs/9829130699#step:7:1054 I will see if/how I can fix this |
OK seems the only way would be to use a personal access token sectet. In this way we can skip the branch protection checks. The In order to do this you should go to mqttjs org and add a personal access token (let's name it Let me know if you can do that. otherwise that action cannot be used for now, not a big deal BTW as I just have to run a command in my end to do the same but could be handy in future to trigger releases from there :) |
I just gave you permissions to the organization, does that work? |
I saw the email, will give that a look tomorrow. Thanks! |
Co-authored-by: Vishnu Reddy <[email protected]>
Also did a quick lint fix on readme