Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error events in a browser environment are emitted without any parameters #1497

Closed
wants to merge 4 commits into from

Conversation

filipomar
Copy link

In a browser, where the setImmediate and nextTick polyfills are needed, the Errors being passed such as this scenario are ignored.

Issue was originally raised here.

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@c8aa654). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 4ab0e17 differs from pull request most recent head ce7d48b. Consider uploading reports for the commit ce7d48b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1497   +/-   ##
=======================================
  Coverage        ?   86.02%           
=======================================
  Files           ?       13           
  Lines           ?     1317           
  Branches        ?        0           
=======================================
  Hits            ?     1133           
  Misses          ?      184           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@robertsLando
Copy link
Member

Supersided by #1626 #1628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants