Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align OnConnectCallback with specs expecting Connack packet #1333

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Align OnConnectCallback with specs expecting Connack packet #1333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cace14
Set noImplicitAny to false in test/typescript/tsconfig.json due to a …
ccarcaci Sep 30, 2021
1323cbb
Add @types/ws in devDependencies
ccarcaci Oct 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,14 @@
},
"devDependencies": {
"@types/node": "^10.0.0",
"@types/ws": "^8.2.0",
"aedes": "^0.42.5",
"airtap": "^3.0.0",
"browserify": "^16.5.0",
"chai": "^4.2.0",
"codecov": "^3.0.4",
"end-of-stream": "^1.4.1",
"global": "^4.3.2",
"aedes": "^0.42.5",
"mkdirp": "^0.5.1",
"mocha": "^4.1.0",
"mqtt-connection": "^4.0.0",
Expand Down
4 changes: 2 additions & 2 deletions types/lib/client.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
IClientReconnectOptions
} from './client-options'
import { Store } from './store'
import { Packet, IConnectPacket, IPublishPacket, IDisconnectPacket, QoS } from 'mqtt-packet'
import { Packet, IConnectPacket, IPublishPacket, IDisconnectPacket, QoS, IConnackPacket } from 'mqtt-packet'

export interface ISubscriptionGrant {
/**
Expand Down Expand Up @@ -66,7 +66,7 @@ export interface ISubscriptionMap {
}
}

export declare type OnConnectCallback = (packet: IConnectPacket) => void
export declare type OnConnectCallback = (packet: IConnackPacket) => void
export declare type OnDisconnectCallback = (packet: IDisconnectPacket) => void
export declare type ClientSubscribeCallback = (err: Error, granted: ISubscriptionGrant[]) => void
export declare type OnMessageCallback = (topic: string, payload: Buffer, packet: IPublishPacket) => void
Expand Down