Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript type is missing (autoUseTopicAlias and autoAssignTopicAlias) #1525

Closed
ogis-yamazaki opened this issue Aug 16, 2022 · 1 comment
Closed

Typescript type is missing (autoUseTopicAlias and autoAssignTopicAlias) #1525

ogis-yamazaki opened this issue Aug 16, 2022 · 1 comment

Comments

@ogis-yamazaki
Copy link
Contributor

The following is a type definition file

https://github.com/mqttjs/MQTT.js/blob/aa49aaf9856fe9f433005e850b490a96505add19/types/lib/client-options.d.ts

The following options seem to be missing.

        autoUseTopicAlias?: boolean
        autoAssignTopicAlias?: boolean
redboltz added a commit to redboltz/MQTT.js that referenced this issue Aug 16, 2022
@redboltz
Fix mqttjs#1524 and mqttjs#1525.
c07ede6 
`topicAliasMaximum` for receiving is designed as setting by MqttClient
option, not setting by CONNECT property.
And it is automatically used as CONNECT property.

However, the document said `topicAliasMaximum` is set by CONNECT
property.
It is bad so I fixed it.

In addition, corresponding typescript definitions are fixed.
@robertsLando
Copy link
Member

Fixed by #1519 and #1612

@redboltz redboltz mentioned this issue Jun 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robertsLando @ogis-yamazaki