Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Add dedicated test case for nested service/targets configuration #627

Merged
merged 1 commit into from
Mar 12, 2023

Conversation

amotl
Copy link
Member

@amotl amotl commented Mar 12, 2023

Hi there,

with GH-558, we added a service plugin which uses a nested dictionary for defining service targets in the configuration file. This patch retroactively brings in a corresponding test case.

With kind regards,
Andreas.

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2023

Codecov Report

Merging #627 (b2f3bdb) into main (87984b0) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #627   +/-   ##
=======================================
  Coverage   40.93%   40.93%           
=======================================
  Files          83       83           
  Lines        3750     3750           
=======================================
  Hits         1535     1535           
  Misses       2215     2215           
Flag Coverage Δ
unittests 40.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@amotl amotl marked this pull request as ready for review March 12, 2023 13:32
@amotl amotl merged commit 142b79e into main Mar 12, 2023
@amotl amotl deleted the amo/test-nested-config branch March 12, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants