console.lua: allow clicking selectable items #15016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a game changer, much appreciated. @bt4ibwem8 was talking to me about this very thing. Personal side of things, absolutely loving that select.lua is now part of mpv. |
guidocella
force-pushed
the
console-mouse
branch
2 times, most recently
from
8215cee
to
b9114b7
Compare
|
Download the artifacts for this pull request: |
|
I think it would be good to keep highlighted item follow mouse pointer. |
guidocella
force-pushed
the
console-mouse
branch
from
b9114b7
to
e6cdc97
Compare
|
Should left mouse click select currently highlighted element instead of mouse position? |
guidocella
force-pushed
the
console-mouse
branch
from
e6cdc97
to
a0ba0e2
Compare
|
I updated the highlight before clicking. Chrome and Firefox separately highlight the lines with keyboard and pointer focus but it might be overkill here. |
This adds click support for the select menu. Scrolling with the wheel already worked. If a custom OSC binds a button to a select.lua script-binding, this lets users keep using the mouse to select an item. While the OSC and the select menu are open at the same time, you can no longer click the OSC's buttons. By using mp.add_key_binding instead of add_forced_key_binding you could click both, but the console's binding would be shadowed by MBTN_LEFT bindings in input.conf.
guidocella
force-pushed
the
console-mouse
branch
from
a0ba0e2
to
8237e61
Compare
kasper93
approved these changes
Oct 8, 2024
Samillion
added a commit
to Samillion/ModernZ
that referenced
this pull request
Oct 9, 2024
After a discussion at mpv that started with this: mpv-player/mpv#15016 It has lead to a complete removal of redundant functions that mpv is already capable of doing from the osc. References: mpv-player/mpv#15031 mpv-player/mpv#15038 Also, increased title max character limit to fix #9
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds click support for the select menu. Scrolling with the wheel already worked.
If a custom OSC binds a button to a select.lua script-binding, this lets users keep using the mouse to select an item.
While the OSC and the select menu are open at the same time, you can no longer click the OSC's buttons. By using mp.add_key_binding instead of add_forced_key_binding you could click both, but the console's binding would be shadowed by MBTN_LEFT bindings in input.conf.
Inspired by https://github.com/Samillion/ModernZ