DOCS/contribute: increase hard column limit to 100 #12706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm guilty of violating this, but surely I can't be the only one. 85 is pretty small and there's plenty of lines in the codebase that go well over that. Surely nobody programs on tiny screens anymore and the kernel raised the limit to 100 a few years ago so let's just copy that.
N-R-K
approved these changes
Oct 21, 2023
| this limit if there's a strong case that not breaking the line will increase | ||
| readability. Going over 85 columns might provoke endless discussions about | ||
| readability. Going over 100 columns might provoke endless discussions about | ||
| whether such a limit is needed or not, so avoid it. |
There was a problem hiding this comment.
Let's quick merge this before someone has a chance to provoke an endless discussion!!
philipl
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm guilty of violating this, but surely I can't be the only one. 85 is pretty small and there's plenty of lines in the codebase that go well over that. Surely nobody programs on tiny screens anymore and the kernel raised the limit to 100 a few years ago so let's just copy that.