Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sub-line-spacing should be allowed to be negative #15728

Closed
6 tasks done
luiscastro193 opened this issue Jan 24, 2025 · 0 comments · Fixed by #15727
Closed
6 tasks done

sub-line-spacing should be allowed to be negative #15728

luiscastro193 opened this issue Jan 24, 2025 · 0 comments · Fixed by #15727
Labels

Comments

@luiscastro193
Copy link

mpv Information

mpv v0.39.0-635-g20375d1133 Copyright © 2000-2025 mpv/MPlayer/mplayer2 projects
 built on Jan 24 2025 09:40:54
libplacebo version: v7.350.0 (v7.349.0-30-g056b8520-dirty)
FFmpeg version: N-118350-ge20ee9f9ae
FFmpeg library versions:
   libavcodec      61.31.101
   libavdevice     61.4.100
   libavfilter     10.6.101
   libavformat     61.9.106
   libavutil       59.55.100
   libswresample   5.4.100
   libswscale      8.13.100

Other Information

- Linux version: Arch
- Kernel Version:
- GPU Model:
- Mesa/GPU Driver Version:
- Window Manager and Version:
- Source of mpv: git
- Latest known working version: Yesterday's build
- Issue started after the following happened: Some recent commit

Reproduction Steps

Set sub-line-spacing to -15.

Expected Behavior

The renderer used to draw the lines closer together.

Actual Behavior

The option is ignored and the following error is printed:

The sub-line-spacing option is out of range: -15
Error parsing option sub-line-spacing (parameter is outside values allowed for option)

Log File

output.txt

Sample Files

No response

I carefully read all instruction and confirm that I did the following:

  • I tested with the latest mpv version to validate that the issue is not already fixed.
  • I provided all required information including system and mpv version.
  • I produced the log file with the exact same set of files, parameters, and conditions used in "Reproduction Steps", with the addition of --log-file=output.txt.
  • I produced the log file while the behaviors described in "Actual Behavior" were actively observed.
  • I attached the full, untruncated log file.
  • I attached the backtrace in the case of a crash.
guidocella added a commit to guidocella/mpv that referenced this issue Jan 24, 2025
FLT_MIN is a small positive number (1.175494e-38), so the check v <
FLT_MIN introduced in 0e7f9c3 made all 0 and negative float option
values error, e.g. panscan=0 or video-align-y=-1.

Fixes 0e7f9c3, fixes mpv-player#15728.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant