-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go back and forward multiple frames at once #10128
Labels
Comments
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Apr 25, 2022
This commit gives the frame-step command the ability to accept an additional argument specifying the amount of frames (forwards or backwards) to step through. By default, it steps forward 1. The frame-back-step command is reworked to simply be a call to frame-step with a -1 value. In the case where the value is exactly 1, mpv will play exactly 1 frame and stop like before. However if a backwards step is requested or multiple frames forward, then mpv will perform a very exact seek. This working well, of course, depends on the pts values in the stream being reliable which may not be the case. As a minor note, MPSEEK_BACKSTEP is renamed to MPSEEK_FRAMESTEP since forward seeks use this as well. Fixes mpv-player#10128.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Apr 25, 2022
This commit gives the frame-step command the ability to accept an additional argument specifying the amount of frames (forwards or backwards) to step through. By default, it steps forward 1. The frame-back-step command is reworked to simply be a call to frame-step with a -1 value. In the case where the value is exactly 1, mpv will play exactly 1 frame and stop like before. However if a backwards step is requested or multiple frames forward, then mpv will perform a very exact seek. This working well, of course, depends on the pts values in the stream being reliable which may not be the case. As a minor note, MPSEEK_BACKSTEP is renamed to MPSEEK_FRAMESTEP since forward seeks use this as well. Fixes mpv-player#10128.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Apr 25, 2022
This commit gives the frame-step command the ability to accept an additional argument specifying the amount of frames (forwards or backwards) to step through. By default, it steps forward 1. The frame-back-step command is reworked to simply be a call to frame-step with a -1 value. In the case where the value is exactly 1, mpv will play exactly 1 frame and stop like before. However if a backwards step is requested or multiple frames forward, then mpv will perform a very exact seek. This working well, of course, depends on the pts values in the stream being reliable which may not be the case. As a minor note, MPSEEK_BACKSTEP is renamed to MPSEEK_FRAMESTEP since forward seeks use this as well. Fixes mpv-player#10128.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Apr 25, 2022
This commit gives the frame-step command the ability to accept an additional argument specifying the amount of frames (forwards or backwards) to step through. By default, it steps forward 1. The frame-back-step command is reworked to simply be a call to frame-step with a -1 value. An additional flag is added that controls how exactly mpv steps through frames. By default, "play" is used which behaves like before. mpv will play through the requested amount of frames before stopping. This is more robust and reliable but could also take much longer if a high amount of frames is requested to be skipped through. This mode only works if mpv is skipping frames forward. Otherwise, the "seek" flag is used which performs a very exact seek. This working well, depends on pts values being reliable which may not always be the case. Frame skipping like this is more of a guess and should be less accurate. As a minor note, MPSEEK_BACKSTEP is renamed to MPSEEK_FRAMESTEP since forward seeks can use this as well. Fixes mpv-player#10128.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Apr 25, 2022
This commit gives the frame-step command the ability to accept an additional argument specifying the amount of frames (forwards or backwards) to step through. By default, it steps forward 1. The frame-back-step command is reworked to simply be a call to frame-step with a -1 value. An additional flag is added that controls how exactly mpv steps through frames. By default, "play" is used which behaves like before. mpv will play through the requested amount of frames before stopping. This is more robust and reliable but could also take much longer if a high amount of frames is requested to be skipped through. This mode only works if mpv is skipping frames forward. Otherwise, the "seek" flag is used which performs a very exact seek. This working well, depends on pts values being reliable which may not always be the case. Frame skipping like this is more of a guess and should be less accurate. As a minor note, MPSEEK_BACKSTEP is renamed to MPSEEK_FRAMESTEP since forward seeks can use this as well. Fixes mpv-player#10128.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Jan 24, 2025
Previously, the default behavior of frame-step and frame-back-step is to play forward 1 frame or seek back 1 frame. We keep this behavior but introduce additional flags to control the exact behavior of the frame stepping. The first argument simply specifies how many frames to go through. The second argument specifies whether to play video to step through frames or to seek to step through frames. Playing through the video to step through frames only works going forwards (otherwise it will always seek). In theory we could use backwards playback for this, but that can be decided later. As a minor note, MPSEEK_BACKSTEP is renamed to MPSEEK_FRAMESTEP since forward seeks can use this as well. Fixes mpv-player#10128.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Jan 25, 2025
Previously, the default behavior of frame-step and frame-back-step is to play forward 1 frame or seek back 1 frame. We keep this behavior but introduce additional flags to control the exact behavior of the frame stepping. The first argument simply specifies how many frames to go through. The second argument specifies whether to play video to step through frames or to seek to step through frames. Playing through the video to step through frames only works going forwards (otherwise it will always seek). In theory we could use backwards playback for this, but that can be decided later. As a minor note, MPSEEK_BACKSTEP is renamed to MPSEEK_FRAMESTEP since forward seeks can use this as well. Fixes mpv-player#10128.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Jan 27, 2025
Previously, the default behavior of frame-step and frame-back-step is to play forward 1 frame or seek back 1 frame. We keep this behavior but introduce additional flags to control the exact behavior of the frame stepping. The first argument simply specifies how many frames to go through. The second argument specifies whether to play video to step through frames or to seek to step through frames. Playing through the video to step through frames only works going forwards (otherwise it will always seek). In theory we could use backwards playback for this, but that can be decided later. As a minor note, MPSEEK_BACKSTEP is renamed to MPSEEK_FRAMESTEP since forward seeks can use this as well. Fixes mpv-player#10128.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Jan 27, 2025
Previously, the default behavior of frame-step and frame-back-step is to play forward 1 frame or seek back 1 frame. We keep this behavior but introduce additional flags to control the exact behavior of the frame stepping. The first argument simply specifies how many frames to go through. The second argument specifies whether to play video to step through frames or to seek to step through frames. Playing through the video to step through frames only works going forwards (otherwise it will always seek). In theory we could use backwards playback for this, but that can be decided later. As a minor note, MPSEEK_BACKSTEP is renamed to MPSEEK_FRAMESTEP since forward seeks can use this as well. Fixes mpv-player#10128.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Jan 27, 2025
Previously, the default behavior of frame-step and frame-back-step is to play forward 1 frame or seek back 1 frame. We keep this behavior but introduce additional flags to control the exact behavior of the frame stepping. The first argument simply specifies how many frames to go through. The second argument specifies whether to play video to step through frames or to seek to step through frames. Playing through the video to step through frames only works going forwards (otherwise it will always seek). In theory we could use backwards playback for this, but that can be decided later. As a minor note, MPSEEK_BACKSTEP is renamed to MPSEEK_FRAMESTEP since forward seeks can use this as well. Fixes mpv-player#10128.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Jan 27, 2025
Previously, the default behavior of frame-step and frame-back-step is to play forward 1 frame or seek back 1 frame. We keep this behavior but introduce additional flags to control the exact behavior of the frame stepping. The first argument simply specifies how many frames to go through. The second argument specifies whether to play video to step through frames or to seek to step through frames. Playing through the video to step through frames only works going forwards (otherwise it will always seek). In theory we could use backwards playback for this, but that can be decided later. As a minor note, MPSEEK_BACKSTEP is renamed to MPSEEK_FRAMESTEP since forward seeks can use this as well. Fixes mpv-player#10128.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Jan 28, 2025
Previously, the default behavior of frame-step and frame-back-step is to play forward 1 frame or seek back 1 frame. We keep this behavior but introduce additional flags to control the exact behavior of the frame stepping. The first argument simply specifies how many frames to go through. The second argument specifies whether to play video to step through frames or to seek to step through frames. Playing through the video to step through frames only works going forwards (otherwise it will always seek). In theory we could use backwards playback for this, but that can be decided later. As a minor note, MPSEEK_BACKSTEP is renamed to MPSEEK_FRAMESTEP since forward seeks can use this as well. Fixes mpv-player#10128.
Dudemanguy
added a commit
that referenced
this issue
Jan 28, 2025
Previously, the default behavior of frame-step and frame-back-step is to play forward 1 frame or seek back 1 frame. We keep this behavior but introduce additional flags to control the exact behavior of the frame stepping. The first argument simply specifies how many frames to go through. The second argument specifies whether to play video to step through frames or to seek to step through frames. Playing through the video to step through frames only works going forwards (otherwise it will always seek). In theory we could use backwards playback for this, but that can be decided later. As a minor note, MPSEEK_BACKSTEP is renamed to MPSEEK_FRAMESTEP since forward seeks can use this as well. Fixes #10128.
Great! Thank you... Better late than never? 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior of the wanted feature
frame-step accepts an argument
Alternative behavior of the wanted feature
frame-back-step accepts an argument
The text was updated successfully, but these errors were encountered: