Skip to content

Commit

Permalink
options: rename --play-dir to --play-direction
Browse files Browse the repository at this point in the history
--play-dir sounds like it has something to do with directories so change
it. The play_dir variable is used a bunch everywhere internally so
whatever just leave it alone instead of renaming that.
  • Loading branch information
Dudemanguy committed Oct 15, 2023
1 parent dea4446 commit 84db908
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions DOCS/interface-changes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ Interface changes
- rename `--sub-ass-force-style` to `--sub-ass-style-override`
- rename `--screenshot-directory` to `--screenshot-dir`
- rename `--watch-later-directory` to `--watch-later-dir`
- rename `--play-dir` to `--play-direction`
--- mpv 0.36.0 ---
- add `--target-contrast`
- Target luminance value is now also applied when ICC profile is used.
Expand Down
4 changes: 2 additions & 2 deletions DOCS/man/options.rst
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ Playback Control
of them fails. This doesn't affect playback of audio-only or video-only
files.

``--play-dir=<forward|+|backward|->``
``--play-direction=<forward|+|backward|->``
Control the playback direction (default: forward). Setting ``backward``
will attempt to play the file in reverse direction, with decreasing
playback time. If this is set on playback starts, playback will start from
Expand Down Expand Up @@ -701,7 +701,7 @@ Playback Control
``--demuxer-backward-playback-step=<seconds>``
Number of seconds the demuxer should seek back to get new packets during
backward playback (default: 60). This is useful for tuning backward
playback, see ``--play-dir`` for details.
playback, see ``--play-direction`` for details.

Setting this to a very low value or 0 may make the player think seeking is
broken, or may make it perform multiple seeks.
Expand Down
3 changes: 2 additions & 1 deletion options/options.c
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ static const m_option_t mp_opts[] = {
{"end", OPT_REL_TIME(play_end)},
{"length", OPT_REL_TIME(play_length)},

{"play-dir", OPT_CHOICE(play_dir,
{"play-direction", OPT_CHOICE(play_dir,
{"forward", 1}, {"+", 1}, {"backward", -1}, {"-", -1})},

{"rebase-start-time", OPT_BOOL(rebase_start_time)},
Expand Down Expand Up @@ -886,6 +886,7 @@ static const m_option_t mp_opts[] = {

{"", OPT_SUBSTRUCT(encode_opts, encode_config)},

{"play-dir", OPT_REPLACED("play-direction")},
{"screenshot-directory", OPT_REPLACED("screenshot-dir")},
{"sub-forced-only", OPT_REPLACED("sub-forced-events-only")},
{"watch-later-directory", OPT_REPLACED("watch-later-dir")},
Expand Down

0 comments on commit 84db908

Please sign in to comment.