Skip to content

Commit

Permalink
address PR comments
Browse files Browse the repository at this point in the history
Signed-off-by: Michael Puncel <[email protected]>
  • Loading branch information
mpuncel committed Aug 7, 2020
1 parent 2f0951e commit 061fc34
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion source/extensions/filters/http/lua/lua_filter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,7 @@ int StreamHandleWrapper::luaImportPublicKey(lua_State* state) {
}

int StreamHandleWrapper::luaBase64Escape(lua_State* state) {
// Get input string
// Get input string.
absl::string_view input = luaL_checkstring(state, 2);
auto output = absl::Base64Escape(input);
lua_pushlstring(state, output.data(), output.length());
Expand Down
6 changes: 3 additions & 3 deletions test/extensions/filters/http/lua/lua_filter_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2198,9 +2198,9 @@ TEST_F(LuaHttpFilterTest, LuaFilterBase64Escape) {
request_handle:logTrace(base64Encoded)
end
function envoy_on_response(request_handle)
local base64Encoded = request_handle:base64Escape("barfoo")
request_handle:logTrace(base64Encoded)
function envoy_on_response(response_handle)
local base64Encoded = response_handle:base64Escape("barfoo")
response_handle:logTrace(base64Encoded)
end
)EOF"};

Expand Down

0 comments on commit 061fc34

Please sign in to comment.