fix: Updated Rumble's tests

mpratt · Nov 17, 2023 · ba0d44d · ba0d44d
1 parent 6138141
commit ba0d44d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/Embera/Provider/Rumble.php b/src/Embera/Provider/Rumble.php
@@ -40,7 +40,10 @@ class Rumble extends ProviderAdapter implements ProviderInterface
     /** inline {@inheritdoc} */
     public function validateUrl(Url $url)
     {
-        return (bool) (preg_match('~rumble\.com/embed/([^/]+)~i', (string) $url));
+        return (bool) (
+            preg_match('~rumble\.com/([^/]+)\.html~i', (string) $url) ||
+            preg_match('~rumble\.com/embed/([^/]+)~i', (string) $url)
+        );
     }
 
     /** inline {@inheritdoc} */

diff --git a/tests/Embera/Provider/RumbleTest.php b/tests/Embera/Provider/RumbleTest.php
@@ -23,10 +23,10 @@ final class RumbleTest extends ProviderTester
         'valid_urls' => [
             'https://rumble.com/v8ind9-hopping-to-go-outside.html',
             'https://rumble.com/v8intx-he-thinks-hes-grown.html',
+            'https://rumble.com/embed/v3tm912/?pub=4',
         ],
         'invalid_urls' => [
             'https://rumble.com/',
-            'https://rumble.com/folder/v8intx-he-thinks-hes-grown.html',
         ],
         'fake_response' => [
             'type' => 'video',