-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CI builds #3
Comments
Hello, @mpoeter, first of all, thanks for providing this wonderful codes, and I'm a strong user in Ubuntu OS. I'm a research who uses xenium for the faster outlier rejection approach, and I have been very satisfied with it. By any chance, would it be possible to support MacOS as well? That would be greatly beneficial for me. Initially, I planned to address this issue myself and submit patches, but I found it overwhelming as it seems beyond my expertise to fix. :( I fixed
|
Hi @LimHyungTae, thank you for the kind words! It seems the problem is not MacOS but the ARM architecture. I always wanted to add support for ARM but unfortunately I have never found the time. I also wanted to move to CircleCI for a long time now (where I could also add some ARM jobs). I will try and see if I can get this done soon. |
You're correct. I tried to build the code on my Apple chip laptop. Take your time! Thanks for the swift response while you are on a hectic day. I'm sure this |
@LimHyungTae I switched to CircleCI, made the adjustments for ARM support and added some Linux ARM CI jobs. I still need to add some Mac jobs, but perhaps you can already give it a try. Ah, and just a heads up - I have renamed the default branch from |
The text was updated successfully, but these errors were encountered: