Implement support for closures #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work.👍 This will take quite a bit of time to review. |
|
@shalvah, How soon will this change be released? |
|
Can't say yet, not sure I'll have time to review until Easter-,ish. |
|
Thanks. Very thorough work. Don't forget to update the documentation as well next time. |
|
@shalvah Thanks for reviewing. Ping me if you need help with the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for closures. The most significant change to the internal API is a move from
ReflectionMethodtoReflectionFunctionAbstractinMpociot\ApiDoc\Extracting\Strategies\Strategy.This is a BC break so tell me if you need more tests. Any comments are appreciated.