-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge with testHook - move package here? #1
Comments
Hey, I was just reading on twitter about This library was more of a proof of concept than anything for me when the hooks alpha was released and I only updated it recently to match the 16.8 changes. When I was checking out I've had a few ideas recently about some changes I want to make to the API, but haven't really locked it down in my head yet. What is here now is a little bit muddled, both in terminology and implementation. I'd almost be comfortable scrapping what is here currently and starting with I'll take a closer look at |
Perhaps I'll do up a table of feature comparisons and we can discuss preferred approaches. |
@alexkrolick looks good so far, check out the PR and let me know what you think. |
I'll leave this open for the time being. The |
I'm going to close this in preference of #15. As for the examples, I'm not sure the API is complex enough to worry with example over and above the README and the test suite, but I'm happy to review any PRs if people want to add them. |
Hi,
Some folks that worked on hook test utils in
react-testing-library
(@kentcdodds, @Donavan) are thinking about extractingtesthook
into its own package. The API is pretty similar to what you have here - would you consider reviewing the current state of that API and merging it withreact-hooks-testing-library
?Discussion: testing-library/react-testing-library#302
WIP Docs for testHook: testing-library/testing-library-docs#32
Next steps:
The text was updated successfully, but these errors were encountered: