-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hooks #32
Hooks #32
Conversation
@@ -0,0 +1,202 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled in these examples from the rtl repo
@@ -0,0 +1,16 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a little FYI blog post about hooks, since they are new in the docs
website/siteConfig.js
Outdated
@@ -95,7 +95,7 @@ const siteConfig = { | |||
/* Colors for website */ | |||
colors: { | |||
primaryColor: '#292422', | |||
secondaryColor: '#3344bb', | |||
secondaryColor: '#2468e5', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated, but the links were hard to read. This is a lighter color so they stand out from the text.
@@ -1,4 +1,3 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This newline broke the svg
Wow! I don't have time to review this PR this week (lots going on this week), but it's fantastic you've done this. Thank you for what you're doing for the community 💯 |
lol, I was actually poking around to see if any more had been done towards this and I see you have tagged me in this (but spelt it wrong so I wasn't notified). If I get time I will take a look at this, otherwise if anyone else wants to take it on, feel free to add yourself as a contributor over on `react-hooks-testing-library] repo. |
Closes #20