Name the asset as a bundle for caching purposes #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naming the asset as a bundle for caching purposes, so the server can add response headers to enable browser caching on */bundle/*.
|
Thanks for your pull request. I'm glad you like the idea behind (my take on) dynamic bundles. I am interested in your pull request and your thinking behind it. However, I'm overseas at the moment. I'll look at it when I'm back home mid September. |
|
Will this ever be merged? If so, I would suggest to use "~/bundles/" with an "s", that seems to be the default naming convention for bundles in ASP.NET. |
|
Will this be merged? Sounds like a performance improvement. |
|
For future readers: I forked dynamicbundles a while ago and merged this pull request over there. https://github.com/RudeySH/dynamicbundles |
|
@RudeySH Oh yes, and yours is available as a NuGet package as well also. I highly recommend to anyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like what you have done with DynamicBundles and am planning on using it in a project; good work.
I thought an enhancement would be to add /bundle/ to the path. The reason is so response headers on /bundle/ can be added to enable browser caching resulting in faster page load time. I tested this by adding cache control rules in IIS on the /bundle/ path and was pleased with the result.
Let me know your thoughts.
Thank you,
Stuart