Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8.1: Lights fall out of sync unless turned off and back on #5

Closed
Lovinity opened this issue Sep 19, 2023 · 2 comments
Closed

0.8.1: Lights fall out of sync unless turned off and back on #5

Lovinity opened this issue Sep 19, 2023 · 2 comments

Comments

@Lovinity
Copy link

This was a previous bug that was fixed in 0.7.2, but it showed up again in 0.8.1...

If I have multiple lights blinking, but I change which lights are blinking (e.g. scrolling through attract sequence tutorials), the lights fall out of sync with their blink patterns. This is probably because the lights that remain blinking on the next attract sequence step do not reset their index in LSC upon a Blink call, thus they fall out of sync with the lights that were off and are newly blinking. I would expect any call for a state change (UpdateInterval is an exception because it's not a state change and would cause problems resetting index on every call) would reset the index back to the beginning (even if the light is already on the requested state).

If you feel resetting the index is not the ideal design decision, which I can understand if that may be true, then please let me know and I'll call an off routine before every blink to hopefully remedy this.

@mpcarr mpcarr closed this as completed in 081b492 Sep 19, 2023
@mpcarr
Copy link
Owner

mpcarr commented Sep 19, 2023

Reset the interval when blink is called. please test

@Lovinity
Copy link
Author

This did not work unfortunately.

I think the issue is that the lights are not resetting to the starting frame when Blink is called (think blink pattern / sequence). I don't think the interval is the issue.

mpcarr added a commit that referenced this issue Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants