Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Add JDK 13 to matrix build #228

Merged
merged 2 commits into from
Jan 13, 2020
Merged

Add JDK 13 to matrix build #228

merged 2 commits into from
Jan 13, 2020

Conversation

sfuhrm
Copy link
Contributor

@sfuhrm sfuhrm commented Jan 11, 2020

Update to newest install-jdk.sh from https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh

Make sure that:

  • You have read the contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

This is a small update of the Travis-CI setup to do a Matrix build with JDK 13.
It's best practice to fail-fast when a problem with new JDKs arises.

@mp911de
Copy link
Owner

mp911de commented Jan 11, 2020

Thanks for the PR. The bach script originates in the time where Travis had difficulties with newer JDK versions. I think we can switch to a more streamlined approach without hosting the script on our repo. Take a look at: https://github.com/spring-projects/spring-data-examples/blob/master/.travis.yml.

@sfuhrm
Copy link
Contributor Author

sfuhrm commented Jan 11, 2020

@mp911de
There's one drawback with the wget option: When the remote repo has an instability/change, travis will fail here.
Anyway, I agree that it makes no sense to mirror something here that does not need to be mirrored.

@mp911de mp911de added the type: task A general task label Jan 13, 2020
@mp911de mp911de added this to the 1.14.0 milestone Jan 13, 2020
@mp911de mp911de merged commit 464ee6e into mp911de:master Jan 13, 2020
@mp911de
Copy link
Owner

mp911de commented Jan 13, 2020

Thank you for your contribution. That's merged now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants