This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
Eliminate double initialization of SSLSession in GelfTCPSSLSender #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move initialization of sslEngine after connect happened
mp911de
reviewed
Jan 22, 2019
| this.sslEngine = sslContext.createSSLEngine(); | ||
| this.sslEngine.setUseClientMode(true); | ||
| this.sslSession = sslEngine.getSession(); | ||
| if (isConnected()) { |
There was a problem hiding this comment.
This check is superfluous as super.connect() does the same check. We can safely remove this if block here.
remove redundant check
mp911de
pushed a commit
that referenced
this pull request
Jan 22, 2019
We now initialize the SSL Engine after the TCP connect succeeded. This change prevents concurrent connects from double initialization of the SSL Engine. It also defers resource creation to a time where we know that the TCP connect was successful. Original pull request: #182.
|
That's squashed, merged and polished now. Thanks a lot! |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #181