Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Add missing Log4j2 plugin configuration #132

Merged
merged 1 commit into from
Feb 16, 2018

Conversation

yuri1969
Copy link
Contributor

The example XML was missing plugin search configuration as described at:
https://logging.apache.org/log4j/2.x/manual/configuration.html#ConfigurationSyntax

Make sure that:

  • You have read the contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@codecov
Copy link

codecov bot commented Feb 16, 2018

Codecov Report

Merging #132 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #132   +/-   ##
=========================================
  Coverage     72.75%   72.75%           
  Complexity      837      837           
=========================================
  Files            60       60           
  Lines          2856     2856           
  Branches        383      383           
=========================================
  Hits           2078     2078           
  Misses          592      592           
  Partials        186      186

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf1b785...dadd3aa. Read the comment docs.

@mp911de
Copy link
Owner

mp911de commented Feb 16, 2018

Thanks a lot. When was packages introduced? Right now, it works also without specifying it.

@mp911de mp911de added this to the logstash-gelf 1.11.3 milestone Feb 16, 2018
@yuri1969
Copy link
Contributor Author

@mp911de TBH, I don't know. A direct copy&paste of the example didn't work since the Gelf appender was not recognized. Pointing the Log4j2 to the right package did the job.

@mp911de
Copy link
Owner

mp911de commented Feb 16, 2018

Cool, thank you.

@mp911de mp911de merged commit d6e86d5 into mp911de:master Feb 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants