Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Make jedis and commons-pool2 dependencies optional #80

Closed
mp911de opened this issue May 17, 2016 · 3 comments
Closed

Make jedis and commons-pool2 dependencies optional #80

mp911de opened this issue May 17, 2016 · 3 comments
Labels
type: enhancement A general enhancement

Comments

@mp911de
Copy link
Owner

mp911de commented May 17, 2016

The jedis Redis driver is marked as mandatory compile dependency in the pom.xml. The driver is not needed at runtime when not using Redis. Switch the dependency to <optional>true</optional> but make sure the dependency is still packaged in the distribution files.

@mp911de mp911de added the type: enhancement A general enhancement label May 17, 2016
@pstrh
Copy link

pstrh commented May 17, 2016

Futhermore the redis libs introduce a detecting dependency convergence which should be fixed.

When including the latest logstash-gelf version (1.9) in our project the maven enforcer plugin reports the folling error:

[WARNING] Rule 0: org.apache.maven.plugins.enforcer.DependencyConvergence failed with message:
Failed while enforcing releasability the error(s) are [
Dependency convergence error for org.apache.commons:commons-pool2:2.3 paths to dependency are:
+-xxx
+-biz.paluch.logging:logstash-gelf:1.9.0
+-redis.clients:jedis:2.8.0
+-org.apache.commons:commons-pool2:2.3
and
+-xxx
+-biz.paluch.logging:logstash-gelf:1.9.0
+-org.apache.commons:commons-pool2:2.4.2
]

@mp911de
Copy link
Owner Author

mp911de commented May 17, 2016

Thanks @psh-tc, will fix that, too.

mp911de added a commit that referenced this issue May 19, 2016
Jedis and commons-pool2 are now optional dependencies as logstash-gelf works without jedis when not using the Redis transport.
mp911de added a commit that referenced this issue May 19, 2016
Fixes also the dependency convergence with commons-pool2 2.4.2 as jedis 2.8.0 declared commons-pool2 2.3
@mp911de
Copy link
Owner Author

mp911de commented May 19, 2016

commons-pool2 version issue fixed by raising Jedis to 2.8.1 which requires commons-pool2 2.4.2

@mp911de mp911de closed this as completed May 19, 2016
@mp911de mp911de added this to the logstash-gelf 1.9.1 milestone May 19, 2016
@mp911de mp911de modified the milestones: logstash-gelf 1.10.0, logstash-gelf 1.9.1 May 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants