Handling Long in GelfUtil.addMdcProfiling

[prlj13]

It looks like handling a Long in GelfUtil.addMdcProfiling isn't done properly. There's a couple of ways to fix it. I'd add an else to the requestStartMs instanceof Long (and removing timestamp == -1 is possible too).

Resulting in something like this:
if (instanceof Long) {...} else if (instanceof String) {...} else {return;}

[mp911de]

Could you elaborate what you mean by not properly? The code could be improved but is there a bug?

[prlj13]

If requestStartMs is a Long, which it looks like addMdcProfiling is supposed to support, then the value is ignored and the duration isn't added to the message.

[mp911de]

requestStartMs must be in any case numeric and can be stored within the MDC either as long (Long) or as String. The latter is used with slf4j's MDC. The code is a leftover from direct MDC usage. LogEvent returns directly a String.

You're totally right, the bug is so obvious that I haven't seen it for years now. Do you want to send in a PR or should I take care of it?

[prlj13]

I'm a newbie (not setup with GIT, just reviewing the source), so I'll let you take care of it.

[mp911de]

Thanks for the bug report, fixed with a916fd1.