-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
alexgibson
commented
Oct 3, 2019
- Add redirector worker for Direct traffic at CRO sandbox versions of pages mozilla/bedrock#7652.
- Add unit tests.
- Update readme.
@jgmize r? |
It seems possible to return the bedrock response directly instead of redirecting. Would that be desirable, or do we for analytics and/or SEO reasons not want to do that? |
I think the answer here is that shadowing could confuse Google since the content would keep changing, but let me double check with Raphael. |
Ok, I double checked with Raphael and he says as long as our experimental pages have a canonical that points to the original URLs (which they do), then a 302 is fine. Shadowing is also ok, but only as long as experiments aren't drastically changing the page. Shadowing is a little more risky, since copy changes could essentially get indexed. |
"url": "https://github.com/mozmeao/www-workers/issues" | ||
}, | ||
"devDependencies": { | ||
"@dollarshaveclub/cloudworker": "^0.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, never thought I'd see dollarshaveclub in a PR :-)
@jgmize I pushed a commit with some review fixes, plus a couple of other small details. Here's a summary:
I've set the updated worker script running on https://www.allizom.org/en-US/firefox/new/ and done some manual testing. It still seems to be working as expecte 👍 |
d84e588
to
14d6592
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @alexgibson!