Add streamforms #17
Merged
Add streamforms #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… landing, which uses the messages framework
This changeset introduces wagtailstreamforms to the project (MIT Licence). It lets us create and configure a form, then choose to include it in a page's StreamField. Submissions are, like wagtailforms, stored in the backend and are downloadable later. Files are uploaded to the default storage bucket. Uploads are also supported. HTML for the form field rendering has been customised to be in the Protocol mould. Custom work done to make Date and Datetime inputs render nicely, plus CSS tweaks for error states and checkbox multi-selects Limitations: * no L10N support * [currently?] unable to disable some field types which are less useful (datetime field) * Spacing between fields isn't super-consistent/automatically just right Future work: * L10N, ideally * Support multiple layout styles for forms (eg columns) * Potentially add Recaptcha, if appropriate
stevejalim
commented
Jul 10, 2023
| @@ -0,0 +1,41 @@ | |||
| // custom CSS overrides for Birdbox, tweaking parts of Protocol | |||
There was a problem hiding this comment.
@craigcook I'd welcome your take on whether this is OK to do, at least in the short-to-medium term, or if it's a hard no-no and we should make the fixes in core Protocol.
(I think that the two newsletter-related CSS tweaks will need to be moved into core Protocol when @alexgibson ports the Basket subscription JS from Bedrock into Protocol)
There was a problem hiding this comment.
It's fine when necessary (we do it often in Bedrock), but if these really are fixes that should also be done upstream let's file an issue in Protocol and try to make sure that happens soon.
There was a problem hiding this comment.
@craigcook Cool - and done: mozilla/protocol#887
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset introduces wagtailstreamforms to the project (MIT Licence).
It lets us create and configure a form, then choose to include it in a page's
StreamField. Submissions are, like wagtailforms, stored in the backend and
are downloadable later. Files are uploaded to the default storage bucket.
Uploads are also supported.
HTML for the form field rendering has been customised to be in the Protocol
mould.
Custom work done to make Date and Datetime inputs render nicely, plus CSS
tweaks for error states and checkbox multi-selects
Limitations:
Future work: