Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use LF for dist files #67

Merged
merged 1 commit into from
May 31, 2018
Merged

Always use LF for dist files #67

merged 1 commit into from
May 31, 2018

Conversation

yfdyh000
Copy link
Contributor

This avoids got inconsistent line breaks and hash for browser-polyfill.min.js when build on Windows.

ref: gruntjs/grunt-contrib-concat#20 (comment)

Rob--W
Rob--W approved these changes Oct 23, 2017
View reviewed changes
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Perhaps we should also have a .gitattributes file to set eol=lf ?

@Rob--W
Copy link
Member

Rob--W commented Apr 6, 2018 •
edited
Loading

I wonder why this hasn't merged yet. Meanwhile I've submitted #103 with the .gitattributes change.

@ExE-Boss ExE-Boss mentioned this pull request May 14, 2018
Closed
@Rob--W Rob--W merged commit 314d2c6 into mozilla:master May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rob--W Rob--W Rob--W approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yfdyh000 @Rob--W