Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add narrative docs for threadsafe instances. #371

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Add narrative docs for threadsafe instances. #371

merged 1 commit into from
Jan 25, 2021

Conversation

rfk
Copy link
Collaborator

@rfk rfk commented Jan 14, 2021

I wrote these docs are part of working through the proposal in #368 and figured I may as well push them for visibility. They may or may not turn out to be a useful starting point for the implementation work connected to #370. /cc @jhugman

@rfk rfk force-pushed the threadsafe-interfaces branch from c598b4b to 11a8297 Compare January 14, 2021 02:09
@rfk
Copy link
Collaborator Author

rfk commented Jan 14, 2021

(N.B. this PR currently targets #367 rather than main, since it builds on top of the docs added therein)

@rfk rfk mentioned this pull request Jan 14, 2021
Closed
@rfk rfk force-pushed the internals-documentation branch from c8f2ce5 to d9f416c Compare January 15, 2021 01:50
Base automatically changed from internals-documentation to main January 15, 2021 01:52
mhammond
mhammond approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get to the end up this, but found a nit I thought I'd share before I take off for the weekend :)

docs/manual/src/internals/lifting_and_lowering.md Outdated

Calling this function from foreign language code involves the following steps:

1. The user-provided calling code invokes the `add_to_list` function that is expoed by the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: exposed

@rfk rfk force-pushed the threadsafe-interfaces branch 2 times, most recently from c44e61d to 958e601 Compare January 25, 2021 04:51
@rfk rfk force-pushed the threadsafe-interfaces branch from 958e601 to 3c10dff Compare January 25, 2021 04:52
@rfk
Copy link
Collaborator Author

rfk commented Jan 25, 2021

This was lightly updated to reflect that actually merged, but I'm going to land it on the strength of Mark's r+.

@rfk rfk marked this pull request as ready for review January 25, 2021 04:52
@rfk rfk changed the title Add speculative documentation for threadsafe instances. Add narrative docs for threadsafe instances. Jan 25, 2021
@rfk rfk merged commit a2e553e into main Jan 25, 2021
@rfk rfk deleted the threadsafe-interfaces branch January 25, 2021 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhammond mhammond mhammond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfk @mhammond