Kotlin classes can inherit from traits. #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhammond
force-pushed
the
push-vptutpmlxunr
branch
from
cb405e4 to
af7b7c5
Compare
bendk
approved these changes
Nov 1, 2024
Builds on mozilla#2204 which landed the metadata and Python support. Also fixes minor issues with `CallbackInterface` types.
mhammond
force-pushed
the
push-vptutpmlxunr
branch
from
af7b7c5 to
9005541
Compare
|
turned out to be a few minor issues with callback interfaces. Then I discovered the trait and struct for that fixture both had the same method with different signatures 🙃 That's an interesting edge-case for the future, but I just avoided doing that for now. Fixed all that and a couple of other tweaks but all of which were sane and small enough that I didn't think it needed a new review. |
mhammond
added a commit
to mhammond/uniffi-rs
that referenced
this pull request
Dec 22, 2024
Builds on mozilla#2196, mozilla#2204 and mozilla#2297. Closes mozilla#2169.
mhammond
added a commit
to mhammond/uniffi-rs
that referenced
this pull request
Dec 22, 2024
Builds on mozilla#2196, mozilla#2204 and mozilla#2297. Closes mozilla#2169.
mhammond
added a commit
that referenced
this pull request
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #2204 which landed the metadata and Python support.