Fully qualify Send and Sync trait in generated code #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what's up with CI, but this can't have broken it! |
dani-garcia
force-pushed
the
fully_qualified_send_sync
branch
from
dc75fca to
ad571fc
Compare
|
Strange, tried rebasing on master and force pushing in case it was a temporary fluke with CI, but it seems to be stuck there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other standard library types were already using a fully qualified name, but that wasn't the case for the
SendandSyncbounds, which will cause issues in any code that has types namedSendorSyncand is using theuniffiproc macros.