Skip to content

Commit

Permalink
One more round of fixups after review
Browse files Browse the repository at this point in the history
  • Loading branch information
bendk committed Jun 14, 2023
1 parent 708a858 commit f1100f0
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
1 change: 0 additions & 1 deletion docs/manual/src/proc_macro/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,6 @@ pub trait Person {
// string name();
// u32 age();
// }
}
```

### Exception handling in callback interfaces
Expand Down
4 changes: 1 addition & 3 deletions uniffi_bindgen/src/backend/filters.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@

//! Backend-agnostic askama filters
use crate::interface::{
CallbackInterface, ComponentInterface, Enum, Function, Object, Record,
};
use crate::interface::{CallbackInterface, ComponentInterface, Enum, Function, Object, Record};
use askama::Result;
use std::fmt;

Expand Down
4 changes: 2 additions & 2 deletions uniffi_macros/src/export/callback_interface.rs
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ pub(super) fn trait_impl(
}
}

impl ::std::mem::Drop for #ident {
impl ::std::ops::Drop for #ident {
fn drop(&mut self) {
#internals_ident.invoke_callback::<(), crate::UniFfiTag>(
self.handle, uniffi::IDX_CALLBACK_FREE, Default::default()
Expand Down Expand Up @@ -87,7 +87,7 @@ fn gen_method_impl(sig: &FnSignature, internals_ident: &Ident) -> syn::Result<To
}
let params = sig.params();
let buf_ident = Ident::new("uniffi_args_buf", Span::call_site());
let mut write_exprs = sig.write_exprs(&buf_ident);
let write_exprs = sig.write_exprs(&buf_ident);

Ok(quote! {
fn #ident(&self, #(#params),*) -> #return_ty {
Expand Down

0 comments on commit f1100f0

Please sign in to comment.