Address second review comments

uniffi/src/bindings/kotlin/templates/ObjectTemplate.kt

@@ -11,16 +11,19 @@ class {{ obj.name()|class_name_kt }}(
     /**
      * Disconnect the object from the underlying Rust object.
      * 
-     * It can be called exactly once. 
+     * It can be called more than once, but once called, interacting with the object 
+     * causes an `IllegalStateException`.
      * 
      * Clients **must** call this method once done with the object, or cause a memory leak.
-     * 
-     * Once this method is called, interacting with the object causes an `IllegalStateException`.
      */
     override fun destroy() {
-        callWithHandle {
-            super.destroy() // poison the handle so no-one else can use it before we tell rust.
-            {% call kt::to_rs_call_with_prefix("it", obj.ffi_object_free()) %}
+        try {
+            callWithHandle {
+                super.destroy() // poison the handle so no-one else can use it before we tell rust.
+                {% call kt::to_rs_call_with_prefix("it", obj.ffi_object_free()) %}
+            }
+        } catch (e: IllegalStateException) {
+            // The user called this more than once. Better than less than once.
         }
     }
 
@@ -30,8 +33,8 @@ class {{ obj.name()|class_name_kt }}(
     {%- when Some with (return_type) -%}
     fun {{ meth.name()|fn_name_kt }}({% call kt::arg_list_decl(meth.arguments()) %}): {{ return_type|type_kt }} {
         val _retval = callWithHandle {
-            {% // Use it here, kotlin's anonymous argument for lambas/closures.
-            -%}
+            {# // Use it here, kotlin's anonymous argument for lambas/closures.
+            -#}
             {% call kt::to_rs_call_with_prefix("it", meth.ffi_func()) %} 
         }
         return {{ "_retval"|lift_kt(return_type) }}

uniffi/src/interface/mod.rs

@@ -416,12 +416,8 @@ impl FFIFunction {
     pub fn return_type(&self) -> Option<&TypeReference> {
         self.return_type.as_ref()
     }
-    pub fn method_arguments(&self) -> Vec<&Argument> {
-        let args = self.arguments.get(1..self.arguments.len());
-        match args {
-            None => Vec::new(),
-            Some(args) => args.iter().collect(),
-        }
+    pub fn method_arguments(&self) -> &[Argument] {
+        self.arguments.get(1..self.arguments.len()).unwrap_or_default()
     }
 }
 

uniffi/src/templates/ObjectTemplate.rs

@@ -17,10 +17,9 @@ lazy_static::lazy_static! {
     pub extern "C" fn {{ ffi_free.name() }}(
         {%- call rs::arg_list_rs_decl(ffi_free.arguments()) %}) {
         log::debug!("{{ ffi_free.name() }}");
-        let _retval = {{ handle_map }}.delete_u64(handle);
+        let _ = {{ handle_map }}.delete_u64(handle);
     }
 
-
 {%- for cons in obj.constructors() %}
 
     #[no_mangle]