Skip to content

Commit

Permalink
More review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
bendk committed Mar 23, 2023
1 parent e19e265 commit 76331d7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fixtures/benchmarks/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ the foreign language:
the benchmarks for.
- `benchmarks.rs` executes a script for each foreign language that we want to benchmark.
- Those scripts call the `run_benchmarks()` function from `lib.rs`
- `run_benchmarks()` parses the CLI arguments again, this time to how to setup
- `run_benchmarks()` parses the CLI arguments again, this time to determine how to setup
the `Criterion` object.
- Testing callback interfaces is relatively straightforward, we simply invoke
the callback method.
- Testing regular functions requires some extra care, since these are called
by the foreign bindings. To test those, `benchmarks.rs` invokes a callback
interface method that call the rust function and reports the time taken.
interface method that calls the Rust function and reports the time taken.

0 comments on commit 76331d7

Please sign in to comment.