Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3305 - Make the length of the short revision hash constant across Treeherder #7914

Merged
merged 2 commits into from
Feb 27, 2024
Merged

3305 - Make the length of the short revision hash constant across Treeherder #7914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c69a7d
3305 - Make the length of the short revision hash constant with bugzilla
florinbilt Feb 21, 2024
c2a7262
3305 - Make the length of the short revision hash constant with bugzilla
florinbilt Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/ui/perfherder/graphs-view/graphs_view_test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ test('Using select query param displays tooltip for correct datapoint', async ()
const graphTooltip = await waitFor(() => getByTestId('graphTooltip'));
const expectedRevision = '3afb892abb74c6d281f3e66431408cbb2e16b8c4';
const revision = await waitFor(() =>
getByText(expectedRevision.slice(0, 13)),
getByText(expectedRevision.slice(0, 12)),
);
const repoName = await waitFor(() => getByTestId('repoName'));
const platform = await waitFor(() => getByTestId('platform'));
Expand All @@ -226,7 +226,7 @@ test('Using select query param displays tooltip for correct datapoint with repli
const graphTooltip = await waitFor(() => getByTestId('graphTooltip'));
const expectedRevision = '3afb892abb74c6d281f3e66431408cbb2e16b8c4';
const revision = await waitFor(() =>
getByText(expectedRevision.slice(0, 13)),
getByText(expectedRevision.slice(0, 12)),
);
const repoName = await waitFor(() => getByTestId('repoName'));
const platform = await waitFor(() => getByTestId('platform'));
Expand Down
2 changes: 1 addition & 1 deletion ui/perfherder/graphs/GraphTooltip.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ const GraphTooltip = ({
<div>
<span>
<a href={pushUrl} target="_blank" rel="noopener noreferrer">
{dataPointDetails.revision.slice(0, 13)}
{dataPointDetails.revision.slice(0, 12)}
</a>{' '}
{(dataPointDetails.jobId || prevRevision) && '('}
{dataPointDetails.jobId && (
Expand Down