Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1823654 - Introduce pyupgrade #7904

Merged

Conversation

yschneider-sinneria
Copy link
Contributor

This MR introduces pyupgrade's syntax rules.

There are 3 commits:

  • 11671af is some easy fixes done by Ruff automatically, mostly string formatting syntax,
  • 1c59886 includes some harder (ruff says unsafe) autofixes,
  • a0a6ea2 includes some final typing.List -> list upgrades

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (a0e7092) 77.08% compared to head (aeaabe5) 76.95%.

Files Patch % Lines
treeherder/model/models.py 20.00% 16 Missing ⚠️
treeherder/webapp/api/push.py 12.50% 7 Missing ⚠️
treeherder/webapp/api/investigated_test.py 0.00% 5 Missing ⚠️
treeherder/webapp/api/jobs.py 16.66% 5 Missing ⚠️
treeherder/perf/models.py 76.47% 4 Missing ⚠️
treeherder/intermittents_commenter/commenter.py 25.00% 3 Missing ⚠️
treeherder/etl/taskcluster_pulse/handler.py 0.00% 2 Missing ⚠️
treeherder/utils/github.py 75.00% 2 Missing ⚠️
tests/webapp/api/test_performance_alerts_api.py 0.00% 1 Missing ⚠️
treeherder/changelog/models.py 0.00% 1 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7904      +/-   ##
==========================================
- Coverage   77.08%   76.95%   -0.14%     
==========================================
  Files         544      544              
  Lines       26943    26931      -12     
  Branches     3377     3377              
==========================================
- Hits        20770    20725      -45     
- Misses       6006     6039      +33     
  Partials      167      167              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archaeopteryx Archaeopteryx merged commit 8028121 into mozilla:master Feb 2, 2024
5 checks passed
Archaeopteryx added a commit to Archaeopteryx/treeherder that referenced this pull request Apr 26, 2024
* Ruff Auto fix

* Ruff unsafe fixes auto fix

* Use builtin list instead of typing.List

---------

Co-authored-by: Sebastian Hengst <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants