-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1823654 - Mostly use double quotes #7900
Bug 1823654 - Mostly use double quotes #7900
Conversation
I see changes in |
After merging this, we should probably do something similar to https://github.com/mozilla/pdf.js/pull/17546/files. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7900 +/- ##
=======================================
Coverage 77.08% 77.08%
=======================================
Files 544 544
Lines 26943 26943
Branches 3377 3377
=======================================
Hits 20770 20770
Misses 6006 6006
Partials 167 167 ☔ View full report in Codecov by Sentry. |
fc0c29a
to
1b95ddd
Compare
@beatrice-acasandrei For your information, this will deployed tomorrow afternoon. |
To be able to ignore these changes when using |
* Enable quote style verifications from Black * Actually exclude migrations folders
In the switch to Ruff's formatter, one of the biggest change will be the usage of double quotes, the usual norm in Python. When black was introduced, that verification was disabled, through the
skip-string-normalization
parameter. It was most surely done to avoid having these massive changes in the same PR.I'm mostly doing this PR to make the change to Ruff less painful.
All files follow the double quote rule except for
migrations
folders, which were excluded fromblack
from the start.Do we still want to avoid formatting them?