Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1823654 - Mostly use double quotes #7900

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

yschneider-sinneria
Copy link
Contributor

In the switch to Ruff's formatter, one of the biggest change will be the usage of double quotes, the usual norm in Python. When black was introduced, that verification was disabled, through the skip-string-normalization parameter. It was most surely done to avoid having these massive changes in the same PR.

I'm mostly doing this PR to make the change to Ruff less painful.

All files follow the double quote rule except for migrations folders, which were excluded from black from the start.
Do we still want to avoid formatting them?

@yschneider-sinneria yschneider-sinneria marked this pull request as ready for review January 25, 2024 10:27
@La0
Copy link
Collaborator

La0 commented Jan 25, 2024

All files follow the double quote rule except for migrations folders, which were excluded from black from the start.

I see changes in migrations though in this PR. I guess we can keep them, I'll check later today with @Archaeopteryx

@marco-c
Copy link
Collaborator

marco-c commented Jan 25, 2024

After merging this, we should probably do something similar to https://github.com/mozilla/pdf.js/pull/17546/files.

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

Attention: 132 lines in your changes are missing coverage. Please review.

Comparison is base (0beab3e) 77.08% compared to head (1b95ddd) 77.08%.

Files Patch % Lines
tests/webapp/api/test_bugzilla.py 61.40% 22 Missing ⚠️
treeherder/intermittents_commenter/commenter.py 51.11% 22 Missing ⚠️
tests/webapp/api/test_performance_alerts_api.py 65.51% 10 Missing ⚠️
tests/webapp/api/test_perfcompare_api.py 87.75% 6 Missing ⚠️
treeherder/model/models.py 93.02% 6 Missing ⚠️
tests/conftest.py 93.05% 5 Missing ⚠️
treeherder/etl/taskcluster_pulse/handler.py 50.00% 5 Missing ⚠️
treeherder/model/error_summary.py 82.75% 5 Missing ⚠️
treeherder/config/settings.py 89.18% 4 Missing ⚠️
treeherder/perf/auto_perf_sheriffing/sherlock.py 63.63% 4 Missing ⚠️
... and 24 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7900   +/-   ##
=======================================
  Coverage   77.08%   77.08%           
=======================================
  Files         544      544           
  Lines       26943    26943           
  Branches     3377     3377           
=======================================
  Hits        20770    20770           
  Misses       6006     6006           
  Partials      167      167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archaeopteryx
Copy link
Collaborator

@beatrice-acasandrei For your information, this will deployed tomorrow afternoon.

@yschneider-sinneria
Copy link
Contributor Author

After merging this, we should probably do something similar to https://github.com/mozilla/pdf.js/pull/17546/files.

To be able to ignore these changes when using git blame, we should probably squash both commits into one. I can do it myself on this PR or when a Maintainer merges it. I don't know what's the norm here.

@Archaeopteryx Archaeopteryx merged commit cfb19a5 into mozilla:master Jan 31, 2024
5 checks passed
Archaeopteryx pushed a commit to Archaeopteryx/treeherder that referenced this pull request Apr 26, 2024
* Enable quote style verifications from Black

* Actually exclude migrations folders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants