Update Marian to v1.12.14 2d067afb 2024-02-16 #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Let's wait to merge for this student to train, as it won't take long: https://firefox-ci-tc.services.mozilla.com/tasks/QV0Lme-0QJardzmk6LegNg/runs/0/logs/live/public/logs/live.log It's been running for about 10 hours without a crash so far, which is a good sign. |
gregtatum
approved these changes
Mar 27, 2024
gabrielBusta
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A student model that failed before is training now: https://firefox-ci-tc.services.mozilla.com/tasks/C6H0G9F_RrSx0zJokDIb_Q/runs/0/logs/live/public/logs/live.log
I did not test the whole pipeline with the new Marian and it will take time to test, but I think we should merge it anyway because the issue is blocking and the upgrade appears to fix it.
fixes #256
fixes #469
[skip ci]