Set TERM for docker worker images #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhearsum
force-pushed
the
term
branch
3 times, most recently
from
9afa5ca to
2fe28f1
Compare
|
I ended up cancel the taskgraph here to save resources - no need to run the entire pipeline to verify this small change to the base docker image. |
I fixed the Taskcluster issue in taskcluster/taskcluster#6856; that will take a couple of weeks to make it to the Firefox CI instance. |
|
Nice. |
gabrielBusta
approved these changes
Feb 27, 2024
nordzilla
pushed a commit
that referenced
this pull request
Sep 19, 2024
Bumps [3rd_party/marian-dev](https://github.com/browsermt/marian-dev) from `300a50f` to `780df27`. - [Commits](browsermt/marian-dev@300a50f...780df27) --- updated-dependencies: - dependency-name: 3rd_party/marian-dev dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to improve issues on docker worker interactive tasks where curses applications don't work correctly.
This is not quite perfect - but it's an improvement. There's seems to be a UI issue in Taskcluster still, where it mixes up x and y size for docker-worker sessions, which leads to a wrongly sized vim window and weird wrapping. I intend to fix that, but that's outside of the scope of this repo.