This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 29
Fix #549: remove name generator for jobs #684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like there isn't a test for this. Could we add one for testing the initial form values on the spark job form? |
robhudson
suggested changes
Aug 23, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've been trying to increase test coverage and this seems like a missing area. Please add a test (or tests) for this form.
test added |
robhudson
approved these changes
Sep 18, 2017
jezdez
pushed a commit
that referenced
this pull request
Nov 15, 2018
Bumps [pycodestyle](https://github.com/PyCQA/pycodestyle) from 2.3.1 to 2.4.0. <details> <summary>Changelog</summary> *Sourced from [pycodestyle's changelog](https://github.com/PyCQA/pycodestyle/blob/master/CHANGES.txt).* > 2.4.0 (2018-04-10) > ------------------ > > New checks: > > * Add W504 warning for checking that a break doesn't happen after a binary > operator. This check is ignored by default. PR [#502](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/502). > * Add W605 warning for invalid escape sequences in string literals. PR [#676](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/676). > * Add W606 warning for 'async' and 'await' reserved keywords being introduced > in Python 3.7. PR [#684](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/684). > * Add E252 error for missing whitespace around equal sign in type annotated > function arguments with defaults values. PR [#717](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/717). > > Changes: > > * An internal bisect search has replaced a linear search in order to improve > efficiency. PR [#648](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/648). > * pycodestyle now uses PyPI trove classifiers in order to document supported > python versions on PyPI. PR [#654](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/654). > * 'setup.cfg' '[wheel]' section has been renamed to '[bdist_wheel]', as > the former is legacy. PR [#653](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/653). > * pycodestyle now handles very long lines much more efficiently for python > 3.2+. Fixes [#643](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/643). PR [#644](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/644). > * You can now write 'pycodestyle.StyleGuide(verbose=True)' instead of > 'pycodestyle.StyleGuide(verbose=True, paths=['-v'])' in order to achieve > verbosity. PR [#663](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/663). > * The distribution of pycodestyle now includes the license text in order to > comply with open source licenses which require this. PR [#694](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/694). > * 'maximum_line_length' now ignores shebang ('#!') lines. PR [#736](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/736). > * Add configuration option for the allowed number of blank lines. It is > implemented as a top level dictionary which can be easily overwritten. Fixes > [#732](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/732). PR [#733](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/733). > > Bugs: > > * Prevent a 'DeprecationWarning', and a 'SyntaxError' in future python, caused > by an invalid escape sequence. PR [#625](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/625). > * Correctly report E501 when the first line of a docstring is too long. > Resolves [#622](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/622). PR [#630](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/630). > * Support variable annotation when variable start by a keyword, such as class > variable type annotations in python 3.6. PR [#640](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/640). > * pycodestyle internals have been changed in order to allow 'python3 -m > cProfile' to report correct metrics. PR [#647](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/647). > * Fix a spelling mistake in the description of E722. PR [#697](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/697). > * 'pycodestyle --diff' now does not break if your 'gitconfig' enables > 'mnemonicprefix'. PR [#706](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/706). </details> <details> <summary>Commits</summary> - [`f73c4bb`](PyCQA/pycodestyle@f73c4bb) Release v2.4.0 - [`72b90c5`](PyCQA/pycodestyle@72b90c5) Merge pull request [#740](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/740) from JakobGM/docs/changes - [`51cf479`](PyCQA/pycodestyle@51cf479) Add PR references from all changelog items - [`6d10bc7`](PyCQA/pycodestyle@6d10bc7) Fixed typo - [`41438bf`](PyCQA/pycodestyle@41438bf) Add changelog items for 2.3.1...master - [`5d31e7e`](PyCQA/pycodestyle@5d31e7e) Add variables so blank lines may be configures - [`9f225ac`](PyCQA/pycodestyle@9f225ac) Ignore length of shebang line ([#736](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/736)) - [`368e62c`](PyCQA/pycodestyle@368e62c) Finalize support for Python 3.7 - [`eb91b79`](PyCQA/pycodestyle@eb91b79) Merge pull request [#684](https://github-redirect.dependabot.com/PyCQA/pycodestyle/issues/684) from jdufresne/async-await - [`01ecae5`](PyCQA/pycodestyle@01ecae5) Updated License / copyright date - Additional commits viewable in [compare view](PyCQA/pycodestyle@2.3.1...2.4.0) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=pycodestyle&package-manager=pip&previous-version=2.3.1&new-version=2.4.0)](https://dependabot.com/compatibility-score.html?dependency-name=pycodestyle&package-manager=pip&previous-version=2.3.1&new-version=2.4.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- **Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit. You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com). <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details>
jezdez
pushed a commit
that referenced
this pull request
Jan 17, 2019
Bumps [marked](https://github.com/markedjs/marked) from 0.5.1 to 0.6.0. <details> <summary>Release notes</summary> *Sourced from [marked's releases](https://github.com/markedjs/marked/releases).* > ## 0.6.0 > ## Breaking Changes > > - Drop support for Node v0.10 and old browsers such as Internet Explorer > - You should not have any problems if using Node 4+ or a modern browser > - Add parameter `slugger` to `Renderer.prototype.heading` method [#1401](https://github-redirect.dependabot.com/markedjs/marked/issues/1401) > - You should not have any problems if you do not override this method > > ## New Features > > - Add new export `marked.Slugger` [#1401](https://github-redirect.dependabot.com/markedjs/marked/issues/1401) > > ## Fixes > > - Fix emphasis followed by a punctuation [#1383](https://github-redirect.dependabot.com/markedjs/marked/issues/1383) > - Fix bold around autolink email address [#1385](https://github-redirect.dependabot.com/markedjs/marked/issues/1385) > - Make autolinks case insensitive [#1384](https://github-redirect.dependabot.com/markedjs/marked/issues/1384) > - Make code fences compliant with Commonmark spec [#1387](https://github-redirect.dependabot.com/markedjs/marked/issues/1387) > - Make blockquote paragraph continuation compliant with Commonmark spec [#1394](https://github-redirect.dependabot.com/markedjs/marked/issues/1394) > - Make ordered list marker length compliant with Commonmark spec [#1391](https://github-redirect.dependabot.com/markedjs/marked/issues/1391) > - Make empty list items compliant with Commonmark spec [#1395](https://github-redirect.dependabot.com/markedjs/marked/issues/1395) > - Make tag escaping compliant with Commonmark spec [#1397](https://github-redirect.dependabot.com/markedjs/marked/issues/1397) > - Make strong/bold compliant with Commonmark spec [#1400](https://github-redirect.dependabot.com/markedjs/marked/issues/1400) > - Fix handling of adjacent lists [#684](https://github-redirect.dependabot.com/markedjs/marked/issues/684) > - Add better error handling when token type cannot be found [#1005](https://github-redirect.dependabot.com/markedjs/marked/issues/1005) > - Fix duplicate heading id and non-latin characters [#1401](https://github-redirect.dependabot.com/markedjs/marked/issues/1401) > > ## CLI > > - Pretty print ENOENT errors on cli [#1396](https://github-redirect.dependabot.com/markedjs/marked/issues/1396) > - Update repo url in man [#1403](https://github-redirect.dependabot.com/markedjs/marked/issues/1403) > > ## Docs > > - Fix `breaks` option description [#1381](https://github-redirect.dependabot.com/markedjs/marked/issues/1381) > - Update docs to include "Since" version [#1382](https://github-redirect.dependabot.com/markedjs/marked/issues/1382) > - Add defibrillator badge for [**mccraveiro**](https://github.com/mccraveiro) [#1392](https://github-redirect.dependabot.com/markedjs/marked/issues/1392) > > ## Tests > > - Remove old test covered by gfm/cm [#1389](https://github-redirect.dependabot.com/markedjs/marked/issues/1389) > > ## 0.5.2 > ## Bug Fixes > > - Fix emphasis closing by single _ (part of left-flanking run) [#1351](https://github-redirect.dependabot.com/markedjs/marked/issues/1351) > - Make URL handling consistent between links and images [#1359](https://github-redirect.dependabot.com/markedjs/marked/issues/1359) > > ## Other > ></table> ... (truncated) </details> <details> <summary>Commits</summary> - [`88a8561`](markedjs/marked@88a8561) Merge pull request [#1404](https://github-redirect.dependabot.com/markedjs/marked/issues/1404) from styfle/release-0.6.0 - [`3160a47`](markedjs/marked@3160a47) 0.6.0 - [`991f3f7`](markedjs/marked@991f3f7) Merge pull request [#1392](https://github-redirect.dependabot.com/markedjs/marked/issues/1392) from UziTech/defibrillator-mccraveiro - [`57fd147`](markedjs/marked@57fd147) 🗜️ minify [skip ci] - [`dfbc9a1`](markedjs/marked@dfbc9a1) Merge pull request [#1401](https://github-redirect.dependabot.com/markedjs/marked/issues/1401) from styfle/slugger2 - [`6dff94d`](markedjs/marked@6dff94d) Merge pull request [#1403](https://github-redirect.dependabot.com/markedjs/marked/issues/1403) from Krinkle/patch-1 - [`0e75ab5`](markedjs/marked@0e75ab5) man: Update bugs url in text version - [`632ac5d`](markedjs/marked@632ac5d) Fix unit tests for slugger - [`5c926e2`](markedjs/marked@5c926e2) Fix slugger & unit tests - [`ffeb807`](markedjs/marked@ffeb807) 🗜️ minify [skip ci] - Additional commits viewable in [compare view](markedjs/marked@v0.5.1...v0.6.0) </details> <details> <summary>Maintainer changes</summary> This version was pushed to npm by [styfle](https://www.npmjs.com/~styfle), a new releaser for marked since your current version. </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=marked&package-manager=npm_and_yarn&previous-version=0.5.1&new-version=0.6.0)](https://dependabot.com/compatibility-score.html?dependency-name=marked&package-manager=npm_and_yarn&previous-version=0.5.1&new-version=0.6.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.