Bug 1273037 - Move from Personal to Google Auth #15

jezdez · 2016-09-16T10:43:21Z

This change is

mozilla-autolander-deprecated · 2016-09-16T10:43:21Z

Autolander could not find a bug number in your pull request title. All pull requests should be in the format of: Bug [number] - [description].

maurodoglio · 2016-09-20T07:37:27Z

Please ping/mention me when this is ready for a review 😺

coveralls · 2016-09-20T10:29:40Z

Coverage decreased (-2.4%) to 77.278% when pulling a6239b2 on allauth into cff0afc on master.

coveralls · 2016-09-20T12:24:42Z

Coverage decreased (-2.9%) to 76.775% when pulling 5af8d85 on allauth into cff0afc on master.

jezdez · 2016-09-20T12:33:08Z

@maurodoglio Okay, this seems good to review, the allauth templates that we're using right now don't match the style and may require some rewording here and there, I'll get to that tomorrow.

When you test this, you won't have to enter credentials separately, I've created a google client ID limited to localhost and it's being automatically added to the database (where allauth stores its creds) during the migrations.

coveralls · 2016-09-20T12:33:40Z

Coverage decreased (-2.9%) to 76.803% when pulling 9d66b87 on allauth into cff0afc on master.

maurodoglio · 2016-09-20T13:09:57Z

atmo/users/adapters.py

+        """
+        if len(accounts) == 1:
+            raise forms.ValidationError(
+                'At least one account needs to be connected to your'


s/ to your//

maurodoglio

looks good to me, there is only a small nit. It's probably worth to squash the commits before merging it.

maurodoglio · 2016-09-20T15:50:11Z

atmo/templates/atmo/dashboard.html

@@ -27,7 +27,13 @@
        <li class="dropdown">
          <a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false">{{ request.user.email }} <span class="caret"></span></a>
          <ul class="dropdown-menu">
-            <li>{% browserid_logout text='Log Out' next='/login' %}</li>
+            {% if request.user.is_authenticated() %}
+            <li><a href="{{ url('account_email') }}">Emails</a></li>


Shouldn't this be a template tag? Maybe it's a leftover from the jinja template?

Actually nevermind, I noticed you fixed it in one of the commits below

peterbe · 2016-09-21T14:01:23Z

atmo/templates/account/login.html

+    </ul>
+  </div>
+  <div class="col-md-6">
+    <h2>Links & resources</h2>


doesn't this need to be &

peterbe · 2016-09-21T14:02:03Z

atmo/users/migrations/0002_google_auth.py

+        defaults={
+            'name': 'Google',
+            'client_id': '559124132137-h9jjj9jm7762uq7u2mn8h8dki7re28tv.apps.googleusercontent.com',
+            'secret': '1iNc8DKhNXoey8jLs4y-E6MN',


I've replaced it with a make task and management command, thanks for the heads-up

coveralls · 2016-09-22T09:04:18Z

Coverage decreased (-2.9%) to 76.803% when pulling d8b5e9d6a53934391cd7a95498b7f7f50a06edeb on allauth into 94c6bf4 on master.

Also: - Rename some classes to just Atmo - Remove unused django-browserid backend

coveralls · 2016-09-22T11:27:40Z

Coverage decreased (-4.04%) to 75.621% when pulling cbf7fcd on allauth into 94c6bf4 on master.

maurodoglio · 2016-09-23T07:06:00Z

Added screenshots to readme

Bumps [notebookjs](https://github.com/jsvine/notebookjs) from 0.3.0 to 0.3.2. <details> <summary>Commits</summary> - [`993e983`](jsvine/notebookjs@993e983) Fix `var lang =` bug and bump to v0.3.2 - [`cd4dcdf`](jsvine/notebookjs@cd4dcdf) Bump to v0.3.1 - [`cfa4831`](jsvine/notebookjs@cfa4831) Merge pull request [#15](https://github-redirect.dependabot.com/jsvine/notebookjs/issues/15) from bradhowes/master - [`d137a66`](jsvine/notebookjs@d137a66) Add support for a custom highlighter function. - [`587f7ef`](jsvine/notebookjs@587f7ef) Add thanks to [**jithurjacob**](https://github.com/jithurjacob) in README.md - See full diff in [compare view](jsvine/notebookjs@v0.3.0...v0.3.2) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=notebookjs&package-manager=npm_and_yarn&previous-version=0.3.0&new-version=0.3.2)](https://dependabot.com/compatibility-score.html?dependency-name=notebookjs&package-manager=npm_and_yarn&previous-version=0.3.0&new-version=0.3.2) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- **Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit. You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com). <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details>

jezdez changed the title ~~Move from Personal to Google Auth~~ Bug 1273037 - Move from Personal to Google Auth Sep 16, 2016

jezdez force-pushed the allauth branch from 10a6a6f to a6239b2 Compare September 20, 2016 10:27

maurodoglio reviewed Sep 20, 2016

View reviewed changes

maurodoglio approved these changes Sep 20, 2016

View reviewed changes

peterbe reviewed Sep 21, 2016

View reviewed changes

Move Debian build script next to other scripts.

ab7f64e

jezdez force-pushed the allauth branch from 9d66b87 to d8b5e9d Compare September 22, 2016 09:02

jezdez added 2 commits September 22, 2016 13:25

Add custom allauth provider for Google OpenIDConnect

ac1cc24

Also: - Rename some classes to just Atmo - Remove unused django-browserid backend

Simplify docker-compose usage with Makefile

cbf7fcd

jezdez force-pushed the allauth branch from d8b5e9d to cbf7fcd Compare September 22, 2016 11:26

jezdez merged commit e49da86 into master Sep 23, 2016

jezdez deleted the allauth branch September 23, 2016 07:50

washort pushed a commit to washort/telemetry-analysis-service that referenced this pull request Aug 15, 2017

Merge pull request mozilla#15 from mreid-moz/documentation

d0ae1bd

Added screenshots to readme

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1273037 - Move from Personal to Google Auth #15

Bug 1273037 - Move from Personal to Google Auth #15

jezdez commented Sep 16, 2016 •

edited by vitillo

Loading

mozilla-autolander-deprecated commented Sep 16, 2016

maurodoglio commented Sep 20, 2016

coveralls commented Sep 20, 2016

coveralls commented Sep 20, 2016

jezdez commented Sep 20, 2016

coveralls commented Sep 20, 2016

maurodoglio Sep 20, 2016

maurodoglio left a comment

maurodoglio Sep 20, 2016

maurodoglio Sep 20, 2016

peterbe Sep 21, 2016

peterbe Sep 21, 2016

jezdez Sep 23, 2016

coveralls commented Sep 22, 2016

coveralls commented Sep 22, 2016

maurodoglio commented Sep 23, 2016

Bug 1273037 - Move from Personal to Google Auth #15

Bug 1273037 - Move from Personal to Google Auth #15

Conversation

jezdez commented Sep 16, 2016 • edited by vitillo Loading

mozilla-autolander-deprecated commented Sep 16, 2016

maurodoglio commented Sep 20, 2016

coveralls commented Sep 20, 2016

coveralls commented Sep 20, 2016

jezdez commented Sep 20, 2016

coveralls commented Sep 20, 2016

maurodoglio Sep 20, 2016

Choose a reason for hiding this comment

maurodoglio left a comment

Choose a reason for hiding this comment

maurodoglio Sep 20, 2016

Choose a reason for hiding this comment

maurodoglio Sep 20, 2016

Choose a reason for hiding this comment

peterbe Sep 21, 2016

Choose a reason for hiding this comment

peterbe Sep 21, 2016

Choose a reason for hiding this comment

jezdez Sep 23, 2016

Choose a reason for hiding this comment

coveralls commented Sep 22, 2016

coveralls commented Sep 22, 2016

maurodoglio commented Sep 23, 2016

jezdez commented Sep 16, 2016 •

edited by vitillo

Loading