This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
Reset cluster expiration email flag after cluster lifetime extension #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 26, 2018 14:57
robhudson
reviewed
Nov 28, 2018
| --hash=sha256:cbfca99bd594a10f674d0cd97a3d802a1fdef635d4361e1a2658de47ed261e3a # pyup: <2.4.0,>=2.0.0 | ||
| pycodestyle==2.3.1 \ | ||
| --hash=sha256:682256a5b318149ca0d2a9185d365d8864a768a28db66a84a2ea946bcc426766 \ | ||
| --hash=sha256:6c4245ade1edfad79c3446fadfc96b0de2759662dc29d07d80a6f27ad1ca6ba9 # pyup: <2.4.0,>=2.0.0 |
There was a problem hiding this comment.
I'm curious why this is here? The old comment was wrong also since it was <2.4.0
There was a problem hiding this comment.
the comment? not sure -- I just did a git revert on the commit that bumped the version so this is what was there before
There was a problem hiding this comment.
Ah, just noticed your comment in the PR. Nevermind. :)
|
@jezdez @robhudson Re-upping this: is there anyone that I should notify before merging this and cutting a new release? |
|
I forget how deploys happen, so I would look towards @jezdez for that. |
|
@sunahsuh Sorry for the delay, I'll try to get this deployed this week. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1101 -- sets the cluster expiration email flag to false when the lifetime is extended
Also includes a revert of #1476, which it looks like should have been in aa4fe07 according to the extended commit message but the actual diff doesn't seem to include it. That change was necessary to get the tests to run.