Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace UTF quote with \u2019 per "./activities.py sort" #652

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

dholbert
Copy link
Contributor

If you run "./activities.py sort" on the repo before this patch (to "Validate activities.json and write it out again in the canonical sorted order"), you get one change, which is precisely the change I'm making here: replacing a fancy UTF single-quote character with its encoded version, \u2019.

It seems we have several other such \u2019 tokens already in this file, so I assume that representation is acceptable. So, this patch makes this replacement, so that ./activities.py sort becomes a no-op.

If you run "./activities.py sort" on the repo before this patch (to "Validate activities.json and write it out again in the canonical sorted order"), you get one change, which is precisely the change I'm making here: replacing a fancy UTF single-quote character with its encoded version, `\u2019`.

It seems we have several other such `\u2019` tokens already in this file, so I assume that representation is acceptable. So, this patch makes this replacement, so that `./activities.py sort` becomes a no-op.
@martinthomson
Copy link
Member

Ugh, contractions... Thanks for fixing, I'll1 take this and then we can consider whether c14n2 is worth enforcing.

Footnotes

  1. Hah! See what I did there!

  2. Again!

@martinthomson martinthomson merged commit d4d7273 into mozilla:main Jun 16, 2022
@dholbert dholbert deleted the patch-1 branch June 16, 2022 17:25
Daasin pushed a commit to FOSS-Archives/standards-positions that referenced this pull request Jan 5, 2023
If you run "./activities.py sort" on the repo before this patch (to "Validate activities.json and write it out again in the canonical sorted order"), you get one change, which is precisely the change I'm making here: replacing a fancy UTF single-quote character with its encoded version, `\u2019`.

It seems we have several other such `\u2019` tokens already in this file, so I assume that representation is acceptable. So, this patch makes this replacement, so that `./activities.py sort` becomes a no-op.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants