Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Permissions Policy position per recent developments #450

Merged
merged 2 commits into from
Oct 13, 2020

Conversation

annevk
Copy link
Contributor

@annevk annevk commented Oct 9, 2020

Closes #24.

cc @johannhof

Copy link

@johannhof johannhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good but I don't think I can merge PRs in this repo :)

activities.json Outdated
@@ -799,7 +799,7 @@
"id": "feature-policy",
"mozBugUrl": "https://bugzilla.mozilla.org/show_bug.cgi?id=1390801",
"mozPosition": "worth prototyping",
"mozPositionDetail": "Mozilla's primary interest in this specification is in the delegation of permissions to third-party contexts, and in particular permissions that might require the user to make a choice. To that end we are willing to prototype and ship the allow attribute, but given this reduction in scope the remaining functionality needs to be reevaluated in terms of naming and applicability.",
"mozPositionDetail": "Mozilla's primary interest in this specification is in the delegation of permissions to third-party contexts that are not granted there by default. To that end we have shipped the allow attribute. The recently revised Permissions-Policy header seems worth prototyping and would allow for sites to impose restrictions on themselves. We hope that the API can be folded into the Permissions API and have not evaluated the reporting functionality as of yet.",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe

We hope that the JavaScript API can be folded into the Permissions API

or DOM API or something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you add that before both occurrences of API? I guess I could do that, but I'm not sure if we consistently do that.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I would think that it's clear from context after the first use.

If we consistently associate "API" with DOM/JS API on the page then that's fine. It just took me a little more time to parse the meaning of that sentence because I associated "the API" to be synonymous with "Permissions Policy as a whole", but it's really not that important :)

Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with clarifying "the API" to disambiguate. That's worth capturing.

activities.json Outdated Show resolved Hide resolved
@annevk annevk requested a review from tantek October 12, 2020 10:12
Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sufficient detail. For any more detail folks can view #24. Thanks

@martinthomson martinthomson merged commit 5742832 into master Oct 13, 2020
@martinthomson martinthomson deleted the annevk/pp branch October 13, 2020 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Policy
4 participants